Stats: Use correct color for visitors #21476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21476-c4ae15f | |
| Commit | c4ae15f | |
| Direct Download | jetpack-prototype-build-pr21476-c4ae15f.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21476-c4ae15f | |
| Commit | c4ae15f | |
| Direct Download | wordpress-prototype-build-pr21476-c4ae15f.apk |
dcalhoun
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Thanks for hunting down the source of the problem.
A couple ideas for the future:
- We might reconsider the use of pink, as I believe the web no longer relies upon it.
- The different colors for views vs visitors was not super clear to me, there might be opportunity to improve the graph labeling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21366
As noted in the issue, in dark mode stats didn't differentiate between views & visitors, instead showing them in the same color. This PR addresses this.
To test, simply verify that views and visitors are shown with different colors in both dark and light modes. Before and after shot below.