Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed feedback link from reading preferences #21466

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

nbradbury
Copy link
Contributor

Fixes #21465

This PR removes the feedback link from the Reading Preferences screen. To test, simply go to Reading Preferences and verify this link no longer appears:

reader

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 14, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 14, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21466-e5f5734
Commite5f5734
Direct Downloadwordpress-prototype-build-pr21466-e5f5734.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 14, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21466-e5f5734
Commite5f5734
Direct Downloadjetpack-prototype-build-pr21466-e5f5734.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury marked this pull request as ready for review November 15, 2024 13:40
@nbradbury nbradbury requested a review from dcalhoun November 15, 2024 15:21
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.49%. Comparing base (24699b0) to head (e5f5734).
Report is 32 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #21466      +/-   ##
==========================================
- Coverage   39.49%   39.49%   -0.01%     
==========================================
  Files        2120     2119       -1     
  Lines       99466    99461       -5     
  Branches    15286    15285       -1     
==========================================
- Hits        39286    39282       -4     
+ Misses      56698    56697       -1     
  Partials     3482     3482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nbradbury nbradbury merged commit ac08ce7 into trunk Nov 18, 2024
23 checks passed
@nbradbury nbradbury deleted the issue/21465-remove-reader-feedback branch November 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove feedback link from reading preferences
4 participants