Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SiteIntentQuestionFeatureConfig #21426

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

nbradbury
Copy link
Contributor

Fixes #21412

This PR removes the SiteIntentQuestionFeatureConfig feature flag. This flag defaulted to true so it was unnecessary.

There's really nothing to test - a green status from CI should suffice.

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 6, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented Nov 6, 2024

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21426-56d9ae5
Commit56d9ae5
Direct Downloadjetpack-prototype-build-pr21426-56d9ae5.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21426-56d9ae5
Commit56d9ae5
Direct Downloadwordpress-prototype-build-pr21426-56d9ae5.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury marked this pull request as ready for review November 6, 2024 13:26
@nbradbury nbradbury requested a review from jkmassel November 6, 2024 13:27
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (a6145b4) to head (56d9ae5).
Report is 110 commits behind head on trunk.

Files with missing lines Patch % Lines
...dpress/android/ui/sitecreation/SiteCreationStep.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21426   +/-   ##
=======================================
  Coverage   39.30%   39.30%           
=======================================
  Files        2121     2120    -1     
  Lines       98326    98322    -4     
  Branches    15233    15232    -1     
=======================================
  Hits        38649    38649           
+ Misses      56238    56234    -4     
  Partials     3439     3439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury merged commit acb4a47 into trunk Nov 12, 2024
25 checks passed
@nbradbury nbradbury deleted the issue/21412-remove-site-intent-config branch November 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary features in development
4 participants