Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site monitoring Material3 #21396

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Site monitoring Material3 #21396

merged 10 commits into from
Nov 5, 2024

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Nov 1, 2024

This PR updates the Site monitoring feature to Material3. It only involves changes to a single file, but those changes were more involved than previous M3 PRs. To test:

  • Make sure the selected site has site monitoring available (ie: an Atomic site)
  • Tap "More..." from the My Site screen
  • Tap "Site monitoring"
  • Verify the site monitoring screen works as it does on trunk

Note: As mentioned here on Slack, we have an issue with this feature where the WebViews aren't showing any data. This is a pre-existing issue unrelated to this PR.

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 1, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 1, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21396-f07664a
Commitf07664a
Direct Downloadjetpack-prototype-build-pr21396-f07664a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 1, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21396-f07664a
Commitf07664a
Direct Downloadwordpress-prototype-build-pr21396-f07664a.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (b9405f4) to head (f07664a).
Report is 18 commits behind head on trunk.

Files with missing lines Patch % Lines
...ndroid/ui/sitemonitor/SiteMonitorParentActivity.kt 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #21396      +/-   ##
==========================================
- Coverage   39.31%   39.30%   -0.01%     
==========================================
  Files        2121     2122       +1     
  Lines       98320    98329       +9     
  Branches    15231    15233       +2     
==========================================
  Hits        38651    38651              
- Misses      56230    56239       +9     
  Partials     3439     3439              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 4, 2024

@nbradbury nbradbury marked this pull request as ready for review November 4, 2024 21:01
@nbradbury nbradbury requested a review from dcalhoun November 4, 2024 21:01
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sound, testing succeeded. I did experience the noted WebView failing to load the metrics.

@nbradbury nbradbury merged commit 73e61e9 into trunk Nov 5, 2024
26 checks passed
@nbradbury nbradbury deleted the issue/sitemonitor-m3 branch November 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants