-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site monitoring Material3 #21396
Site monitoring Material3 #21396
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21396 +/- ##
==========================================
- Coverage 39.31% 39.30% -0.01%
==========================================
Files 2121 2122 +1
Lines 98320 98329 +9
Branches 15231 15233 +2
==========================================
Hits 38651 38651
- Misses 56230 56239 +9
Partials 3439 3439 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sound, testing succeeded. I did experience the noted WebView failing to load the metrics.
This PR updates the Site monitoring feature to Material3. It only involves changes to a single file, but those changes were more involved than previous M3 PRs. To test:
trunk
Note: As mentioned here on Slack, we have an issue with this feature where the WebViews aren't showing any data. This is a pre-existing issue unrelated to this PR.