[Deps] Migrate to Version Catalogs #21262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Build environment changesThe following changes in the build classpath were detected: listtree++--- androidx.navigation.safeargs.kotlin:androidx.navigation.safeargs.kotlin.gradle.plugin:2.7.7
+| \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.7.7
+| \--- org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0 -> 1.9.24
+| \--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:1.9.24
+| +--- org.jetbrains.kotlin:kotlin-allopen:1.9.24 (c)
+| \--- org.jetbrains.kotlin:kotlin-serialization:1.9.24 (c)
++--- com.android.application:com.android.application.gradle.plugin:8.5.1
+| \--- com.android.tools.build:gradle:8.5.1 (*)
++--- org.jetbrains.kotlin.plugin.allopen:org.jetbrains.kotlin.plugin.allopen.gradle.plugin:1.9.24
+| \--- org.jetbrains.kotlin:kotlin-allopen:1.9.24
+| +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:1.9.24 (*)
+| +--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:1.9.24 (*)
+| \--- org.jetbrains.kotlin:kotlin-gradle-plugin-model:1.9.24 (*)
++--- org.jetbrains.kotlin.android:org.jetbrains.kotlin.android.gradle.plugin:1.9.24
+| \--- org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.24 (*)
++--- org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin:1.9.24
+| \--- org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.24 (*)
+\--- org.jetbrains.kotlin.plugin.serialization:org.jetbrains.kotlin.plugin.serialization.gradle.plugin:1.9.24
+ \--- org.jetbrains.kotlin:kotlin-serialization:1.9.24
+ +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:1.9.24 (*)
+ \--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:1.9.24 (*) |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21262-c8240a7 | |
| Commit | c8240a7 | |
| Direct Download | jetpack-prototype-build-pr21262-c8240a7.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21262-c8240a7 | |
| Commit | c8240a7 | |
| Direct Download | wordpress-prototype-build-pr21262-c8240a7.apk |
This configuration was added as part of this b2bf8b1 initial module setup commit, but never had any effect. As such, it is removed from the list of dependencies to make cleanup the dependency block from unnecessary configuration, which also needs not be migrated to version catalogs.
The AGP update is done manually.
ParaskP7
force-pushed
the
deps/migrate-to-version-catalogs
branch
from
a1fa658 to
d7fa850
Compare
6 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nbradbury
reviewed
Sep 30, 2024
| @@ -43,8 +43,6 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation fileTree(dir: 'libs', include: ['*.jar']) | |||
nbradbury
reviewed
Sep 30, 2024
| @@ -24,10 +24,6 @@ ext { | |||
| ext { | |||
| // main | |||
| androidxComposeNavigationVersion = '2.7.7' | |||
| androidxGridlayoutVersion = '1.0.0' | |||
There was a problem hiding this comment.
👋 @nbradbury !
These variables you see there are just versions that could be potentially used (were used in the past) on a dependency/library. When there is no dependency associated with those, there is nothing buildHealth or 
can do identify those "unused" version related variables to report them as such.
Does that make sense? 🙏
wzieba
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Looks good. I'm especially glad that the runtime dependencies are not change by this PR, which proves a thoughtful migration. 👏
About build classpath changes - they're expected, as we now declare (but not apply) more plugins in the root project. I'm okay with this and I think this is even better as some plugins authors expect us to do this, e.g. AGP (docs).
|
Awesome, thank you both @nbradbury and @wzieba for the review, to version catalogs and beyond! 🎉 ❤️ 🚀 |
|
FYI: I just noticed yesterday a missing |
|
ParaskP7
added a commit
that referenced
this pull request
Oct 18, 2024
This is a leftover from the 'Version Catalogs' migration work. FYI: During a WCAndroid release, the 'complete_code_freeze' workflow failed due to the fact that the old, non-version-catalogs related versions couldn't be referenced any more. The same will apply to JP/WPAndroid when a new release will commence. This change addresses that. JP/WPAndroid PR: [Deps] Migrate to Version Catalogs #21262 - #21262 WCAndroid PR: Release/20.8 update import keys #12799 - woocommerce/woocommerce-android#12799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Thread: paaHJt-7cv-p2
This PR migrates all dependencies and plugins in this project to Version Catalogs and under the newly created gradle/libs.versions.toml file.
Description
FYI: I recommend reviewing this PR commit-by-commit just to make sure that every dependency and plugin has been migrated appropriately, just to make sure that there isn't any left-overs that need addressing.
PS: The gradle/libs.versions.toml file, on both, its
versionsandlibrariessections:dash-case) .orgname is added in its prefix to group dependencies together and make them easily identifiable.mainis added in its suffix to make sure that a dependency cannot be a parent of another dependency and a dependency itself. This helps in various corner cases.To Test:
JetpackandWordPressapps, and verify everything is working as expected../gradlew buildHealthtask locally and verify that everything is working as expected (CI).Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
N/A