Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FluxC Hash #21218

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Sep 9, 2024

This PR updates the FluxC hash to include changes added in this PR. To test, select a blog with a large number of posts and verify scrolling through the post list works as expected.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

-+--- org.wordpress:fluxc:{strictly trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42} -> trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.7.0 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.7 (*)
-|    +--- androidx.security:security-crypto:1.0.0
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.2 (*)
-|    |    \--- com.google.crypto.tink:tink-android:1.5.0
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)
-|    +--- org.apache.commons:commons-text:1.10.0 -> 1.12.0
-|    |    \--- org.apache.commons:commons-lang3:3.14.0
-|    +--- androidx.room:room-runtime:2.6.1
-|    |    +--- androidx.annotation:annotation-experimental:1.1.0-rc01 -> 1.4.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.2.0 (*)
-|    |    +--- androidx.room:room-common:2.6.1
-|    |    |    +--- androidx.annotation:annotation:1.3.0 -> 1.8.2 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 1.9.10 (*)
-|    |    |    +--- androidx.room:room-ktx:2.6.1 (c)
-|    |    |    \--- androidx.room:room-runtime:2.6.1 (c)
-|    |    +--- androidx.sqlite:sqlite:2.4.0
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
-|    |    |    \--- androidx.sqlite:sqlite-framework:2.4.0 (c)
-|    |    +--- androidx.sqlite:sqlite-framework:2.4.0
-|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
-|    |    |    +--- androidx.sqlite:sqlite:2.4.0 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
-|    |    |    \--- androidx.sqlite:sqlite:2.4.0 (c)
-|    |    +--- androidx.room:room-common:2.6.1 (c)
-|    |    \--- androidx.room:room-ktx:2.6.1 (c)
-|    +--- androidx.room:room-ktx:2.6.1
-|    |    +--- androidx.room:room-common:2.6.1 (*)
-|    |    +--- androidx.room:room-runtime:2.6.1 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
-|    |    +--- androidx.room:room-common:2.6.1 (c)
-|    |    \--- androidx.room:room-runtime:2.6.1 (c)
-|    +--- com.google.dagger:dagger:2.51.1
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42
-|    +--- org.greenrobot:eventbus:3.3.1
-|    |    \--- org.greenrobot:eventbus-java:3.3.1
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.1
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.8.5 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.8.5 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0 -> 5.14.0
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.0 (*)
++--- org.wordpress:fluxc:{strictly trunk-a77c116b8bd00247c8c0551b4497629ff84ca023} -> trunk-a77c116b8bd00247c8c0551b4497629ff84ca023
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.7 (*)
+|    +--- androidx.security:security-crypto:1.0.0
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.2 (*)
+|    |    \--- com.google.crypto.tink:tink-android:1.5.0
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)
+|    +--- org.apache.commons:commons-text:1.10.0 -> 1.12.0
+|    |    \--- org.apache.commons:commons-lang3:3.14.0
+|    +--- androidx.room:room-runtime:2.6.1
+|    |    +--- androidx.annotation:annotation-experimental:1.1.0-rc01 -> 1.4.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.2.0 (*)
+|    |    +--- androidx.room:room-common:2.6.1
+|    |    |    +--- androidx.annotation:annotation:1.3.0 -> 1.8.2 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 1.9.10 (*)
+|    |    |    +--- androidx.room:room-ktx:2.6.1 (c)
+|    |    |    \--- androidx.room:room-runtime:2.6.1 (c)
+|    |    +--- androidx.sqlite:sqlite:2.4.0
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+|    |    |    \--- androidx.sqlite:sqlite-framework:2.4.0 (c)
+|    |    +--- androidx.sqlite:sqlite-framework:2.4.0
+|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
+|    |    |    +--- androidx.sqlite:sqlite:2.4.0 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+|    |    |    \--- androidx.sqlite:sqlite:2.4.0 (c)
+|    |    +--- androidx.room:room-common:2.6.1 (c)
+|    |    \--- androidx.room:room-ktx:2.6.1 (c)
+|    +--- androidx.room:room-ktx:2.6.1
+|    |    +--- androidx.room:room-common:2.6.1 (*)
+|    |    +--- androidx.room:room-runtime:2.6.1 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
+|    |    +--- androidx.room:room-common:2.6.1 (c)
+|    |    \--- androidx.room:room-runtime:2.6.1 (c)
+|    +--- com.google.dagger:dagger:2.51.1
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+|    +--- org.wordpress:wellsql:2.0.0
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-a77c116b8bd00247c8c0551b4497629ff84ca023
+|    +--- org.greenrobot:eventbus-java:3.3.1
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.1
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.8.5 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.8.5 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0 -> 5.14.0
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.0 (*)
 +--- org.wordpress:utils:{strictly 3.14.0} -> 3.14.0
-|    \--- org.greenrobot:eventbus:3.3.1 (*)
+|    \--- org.greenrobot:eventbus:3.3.1
+|         \--- org.greenrobot:eventbus-java:3.3.1
 \--- org.wordpress:login:1.16.0
-     \--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42 (*)
+     \--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-a77c116b8bd00247c8c0551b4497629ff84ca023 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 9, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21218-26755f3
Commit26755f3
Direct Downloadwordpress-prototype-build-pr21218-26755f3.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 9, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21218-26755f3
Commit26755f3
Direct Downloadjetpack-prototype-build-pr21218-26755f3.apk
Note: Google Login is not supported on these builds.

Copy link

sonarqubecloud bot commented Sep 9, 2024

@nbradbury nbradbury marked this pull request as ready for review September 10, 2024 11:59
Copy link
Contributor

@atorresveiga atorresveiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@nbradbury nbradbury merged commit afc5fb2 into trunk Sep 16, 2024
20 checks passed
@nbradbury nbradbury deleted the issue/fluxc-a77c116b8bd00247c8c0551b4497629ff84ca023 branch September 16, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants