-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FluxC Hash #21218
Merged
nbradbury
merged 3 commits into
trunk
from
issue/fluxc-a77c116b8bd00247c8c0551b4497629ff84ca023
Sep 16, 2024
Merged
Update FluxC Hash #21218
nbradbury
merged 3 commits into
trunk
from
issue/fluxc-a77c116b8bd00247c8c0551b4497629ff84ca023
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Found 1 violations: The PR caused some dependency changes (expand to see details)
-+--- org.wordpress:fluxc:{strictly trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42} -> trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 (*)
-| +--- androidx.appcompat:appcompat:1.0.2 -> 1.7.0 (*)
-| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-| +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.7 (*)
-| +--- androidx.security:security-crypto:1.0.0
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.8.2 (*)
-| | \--- com.google.crypto.tink:tink-android:1.5.0
-| +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
-| +--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)
-| +--- org.apache.commons:commons-text:1.10.0 -> 1.12.0
-| | \--- org.apache.commons:commons-lang3:3.14.0
-| +--- androidx.room:room-runtime:2.6.1
-| | +--- androidx.annotation:annotation-experimental:1.1.0-rc01 -> 1.4.0 (*)
-| | +--- androidx.arch.core:core-runtime:2.2.0 (*)
-| | +--- androidx.room:room-common:2.6.1
-| | | +--- androidx.annotation:annotation:1.3.0 -> 1.8.2 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 1.9.10 (*)
-| | | +--- androidx.room:room-ktx:2.6.1 (c)
-| | | \--- androidx.room:room-runtime:2.6.1 (c)
-| | +--- androidx.sqlite:sqlite:2.4.0
-| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
-| | | \--- androidx.sqlite:sqlite-framework:2.4.0 (c)
-| | +--- androidx.sqlite:sqlite-framework:2.4.0
-| | | +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
-| | | +--- androidx.sqlite:sqlite:2.4.0 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
-| | | \--- androidx.sqlite:sqlite:2.4.0 (c)
-| | +--- androidx.room:room-common:2.6.1 (c)
-| | \--- androidx.room:room-ktx:2.6.1 (c)
-| +--- androidx.room:room-ktx:2.6.1
-| | +--- androidx.room:room-common:2.6.1 (*)
-| | +--- androidx.room:room-runtime:2.6.1 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
-| | +--- androidx.room:room-common:2.6.1 (c)
-| | \--- androidx.room:room-runtime:2.6.1 (c)
-| +--- com.google.dagger:dagger:2.51.1
-| | \--- javax.inject:javax.inject:1
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-| +--- org.wordpress:wellsql:2.0.0
-| | +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
-| | \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-| +--- org.wordpress.fluxc:fluxc-annotations:trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42
-| +--- org.greenrobot:eventbus:3.3.1
-| | \--- org.greenrobot:eventbus-java:3.3.1
-| +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-| +--- com.android.volley:volley:1.1.1 -> 1.2.1
-| +--- androidx.paging:paging-runtime:2.1.2
-| | +--- androidx.paging:paging-common:2.1.2
-| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
-| | | \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-| | +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-| | +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.8.5 (*)
-| | +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.8.5 (*)
-| | \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-| +--- com.goterl:lazysodium-android:5.0.2
-| +--- net.java.dev.jna:jna:5.5.0 -> 5.14.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.0 (*)
++--- org.wordpress:fluxc:{strictly trunk-a77c116b8bd00247c8c0551b4497629ff84ca023} -> trunk-a77c116b8bd00247c8c0551b4497629ff84ca023
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 (*)
+| +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.7 (*)
+| +--- androidx.security:security-crypto:1.0.0
+| | +--- androidx.annotation:annotation:1.1.0 -> 1.8.2 (*)
+| | \--- com.google.crypto.tink:tink-android:1.5.0
+| +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
+| +--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)
+| +--- org.apache.commons:commons-text:1.10.0 -> 1.12.0
+| | \--- org.apache.commons:commons-lang3:3.14.0
+| +--- androidx.room:room-runtime:2.6.1
+| | +--- androidx.annotation:annotation-experimental:1.1.0-rc01 -> 1.4.0 (*)
+| | +--- androidx.arch.core:core-runtime:2.2.0 (*)
+| | +--- androidx.room:room-common:2.6.1
+| | | +--- androidx.annotation:annotation:1.3.0 -> 1.8.2 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 1.9.10 (*)
+| | | +--- androidx.room:room-ktx:2.6.1 (c)
+| | | \--- androidx.room:room-runtime:2.6.1 (c)
+| | +--- androidx.sqlite:sqlite:2.4.0
+| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+| | | \--- androidx.sqlite:sqlite-framework:2.4.0 (c)
+| | +--- androidx.sqlite:sqlite-framework:2.4.0
+| | | +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
+| | | +--- androidx.sqlite:sqlite:2.4.0 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+| | | \--- androidx.sqlite:sqlite:2.4.0 (c)
+| | +--- androidx.room:room-common:2.6.1 (c)
+| | \--- androidx.room:room-ktx:2.6.1 (c)
+| +--- androidx.room:room-ktx:2.6.1
+| | +--- androidx.room:room-common:2.6.1 (*)
+| | +--- androidx.room:room-runtime:2.6.1 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
+| | +--- androidx.room:room-common:2.6.1 (c)
+| | \--- androidx.room:room-runtime:2.6.1 (c)
+| +--- com.google.dagger:dagger:2.51.1
+| | \--- javax.inject:javax.inject:1
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+| +--- org.wordpress:wellsql:2.0.0
+| | +--- androidx.annotation:annotation:1.2.0 -> 1.8.2 (*)
+| | \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+| +--- org.wordpress.fluxc:fluxc-annotations:trunk-a77c116b8bd00247c8c0551b4497629ff84ca023
+| +--- org.greenrobot:eventbus-java:3.3.1
+| +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+| +--- com.android.volley:volley:1.1.1 -> 1.2.1
+| +--- androidx.paging:paging-runtime:2.1.2
+| | +--- androidx.paging:paging-common:2.1.2
+| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.2 (*)
+| | | \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+| | +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+| | +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.8.5 (*)
+| | +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.8.5 (*)
+| | \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+| +--- com.goterl:lazysodium-android:5.0.2
+| +--- net.java.dev.jna:jna:5.5.0 -> 5.14.0
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.0 (*)
+--- org.wordpress:utils:{strictly 3.14.0} -> 3.14.0
-| \--- org.greenrobot:eventbus:3.3.1 (*)
+| \--- org.greenrobot:eventbus:3.3.1
+| \--- org.greenrobot:eventbus-java:3.3.1
\--- org.wordpress:login:1.16.0
- \--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42 (*)
+ \--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-a77c116b8bd00247c8c0551b4497629ff84ca023 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Quality Gate passedIssues Measures |
atorresveiga
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nbradbury
deleted the
issue/fluxc-a77c116b8bd00247c8c0551b4497629ff84ca023
branch
September 16, 2024 16:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the FluxC hash to include changes added in this PR. To test, select a blog with a large number of posts and verify scrolling through the post list works as expected.