-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: ActivityNotFoundException for camera #20744
Conversation
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20744 +/- ##
==========================================
- Coverage 40.62% 40.62% -0.01%
==========================================
Files 1489 1489
Lines 68531 68533 +2
Branches 11326 11327 +1
==========================================
Hits 27841 27841
- Misses 38161 38163 +2
Partials 2529 2529 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 All is working as expected. I did not experience any issues with camera launch. Thanks @pantstamp
Fixes #20279
This PR tries to fix the crash reported in this Sentry issue.
This seems to be a minor crash that occurs when a device is trying to launch camera but it cannot access it.
Adds a
onCameraError(String errorMessage);
function in theinterface LaunchCameraCallback
that can be used also with other camera related errors in the future.To Test:
MediaBrowserActivity
MediaPickerActivity
PhotoPickerActivity
EditPostActivity
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):