Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty bar chart issue #20674

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix empty bar chart issue #20674

merged 1 commit into from
Apr 19, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Apr 18, 2024

This fixes an issue that is introduced with #20605.
Some cards were stuck in the loading state, and the date picker was disabled.

I added values with 0f to the chart data to fix the issue.

before after

To Test:

  1. Log in.
  2. Select a site with empty stats. (You can create a fresh one)
  3. Open the DAYS tab from "My Site → Stats"

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • This reverts some part of previous PR.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@irfano irfano requested a review from aditi-bhatia April 18, 2024 18:52
@irfano irfano added this to the 24.8 milestone Apr 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20674-a2e569d
Commita2e569d
Direct Downloadwordpress-prototype-build-pr20674-a2e569d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20674-a2e569d
Commita2e569d
Direct Downloadjetpack-prototype-build-pr20674-a2e569d.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.27%. Comparing base (921ce21) to head (a2e569d).

Additional details and impacted files
@@             Coverage Diff             @@
##            trunk   #20674       +/-   ##
===========================================
- Coverage   82.58%   40.27%   -42.32%     
===========================================
  Files          15     1476     +1461     
  Lines         534    68115    +67581     
  Branches       50    11281    +11231     
===========================================
+ Hits          441    27431    +26990     
- Misses         75    38190    +38115     
- Partials       18     2494     +2476     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aditi-bhatia aditi-bhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for fixing this 👍

@aditi-bhatia aditi-bhatia merged commit 7722b6e into trunk Apr 19, 2024
21 of 22 checks passed
@aditi-bhatia aditi-bhatia deleted the fix/empty-bar-chart-issue branch April 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants