-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Add singular strings to weekly roundup notification #20608
Stats: Add singular strings to weekly roundup notification #20608
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Fix StringFormatCount lint error
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20608 +/- ##
==========================================
- Coverage 40.39% 40.39% -0.01%
==========================================
Files 1474 1474
Lines 67906 67920 +14
Branches 11226 11231 +5
==========================================
+ Hits 27433 27438 +5
- Misses 37994 38000 +6
- Partials 2479 2482 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixed a lint issue to merge.
Fixes #17824
This fixes using the plural form of "view" and "comment" for singular values on Weekly roundup notifications.
Additionally, this fixes false positive test cases for
buildNotifications should not include likes and comments with 0 count
buildNotifications should not include likes with 0 count
buildNotifications should not include comments with 0 count
buildNotifications should include views, likes, and comments greater than zero
in
WeeklyRoundupNotifierTest
. Before, it was always checking"mock_string" == "mock_string
", which was always true.To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
WeeklyRoundupNotifierTest
.PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
WordPress.com sites and self-hosted Jetpack sites.Portrait and landscape orientations.Light and dark modes.Fonts: Larger, smaller and bold text.High contrast.Talkback.Languages with large words or with letters/accents not frequently used in English.Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)Large and small screen sizes. (Tablet and smaller phones)Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)