-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stats] Add year to date picker for weeks. #20589
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notandyvee , can we make this change for only the traffic tab by checking stats_traffic_tab
flag. The iOS is also doing it this way.
Additionally, I noticed that StatsDateFormatterTest
is failing.
That's fine. I'll make the changes. |
…arity. Additionally fixing some test failures.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20589 +/- ##
=======================================
Coverage 40.34% 40.34%
=======================================
Files 1473 1473
Lines 67875 67877 +2
Branches 11224 11224
=======================================
+ Hits 27386 27387 +1
- Misses 38023 38024 +1
Partials 2466 2466 ☔ View full report in Codecov by Sentry. |
@irfano ready for re-review. Fixed the unit tests and added the feature flag check. |
WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/utils/StatsDateFormatterTest.kt
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
Fixes #20488
Add year to the week granularity label in datepicker. The screenshot below is on a small screen width.
Note: this affects both the stats that is currently out to everyone and the traffic tab under the week granularity.
To Test:
stats_traffic_tab
feature flag in debug settings.stats_traffic_tab
.Regression Notes
Potential unintended areas of impact
This would only affect adding the year to the date picker label on the old stats week granularity.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual test.
What automated tests I added (or what prevented me from doing so)
n/a
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.