Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats traffic fix graph issues #20336

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Stats traffic fix graph issues #20336

merged 3 commits into from
Mar 1, 2024

Conversation

ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Feb 29, 2024

Fixes #
#20312
#20311

Week Year Detail
Screenshot_20240229_184934 Screenshot_20240229_184956 Screenshot_20240229_184915

To Test:

  • Enable Stats Traffic Feature flag
  • Open Stats
  • Open Traffic tab

Bar graph

  • Select By week/year
  • Verify the bars now start at base, and no gap as in Week, Year images above

Detail Views Graph

  • Select Posts & Pages card
  • Go to detail view
  • Ensure the graph is show as in the third image above

Regression Notes

  1. Potential unintended areas of impact

    • No unintended impact
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • tested all bar charts
  3. What automated tests I added (or what prevented me from doing so)

    • existing unit tests

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Fix for week, and year bars starting above zero.
Created a separate TrafficBarChartItem to avoid collision with detail views bar chart
@ravishanker ravishanker added this to the 24.4 milestone Feb 29, 2024
@ravishanker ravishanker requested a review from irfano February 29, 2024 08:03
@ravishanker ravishanker marked this pull request as ready for review February 29, 2024 08:03
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 29, 2024

2 Warnings
⚠️ Class TrafficBarChartItem is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ This PR is assigned to the milestone 24.4. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 29, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20336-5f6bcd1
Commit5f6bcd1
Direct Downloadjetpack-prototype-build-pr20336-5f6bcd1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 29, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20336-5f6bcd1
Commit5f6bcd1
Direct Downloadwordpress-prototype-build-pr20336-5f6bcd1.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 40.18%. Comparing base (1f30dda) to head (5f6bcd1).
Report is 8 commits behind head on trunk.

Files Patch % Lines
...press/android/ui/stats/refresh/utils/StatsUtils.kt 0.00% 19 Missing ⚠️
...d/ui/stats/refresh/lists/sections/BlockListItem.kt 10.00% 9 Missing ⚠️
...sh/lists/sections/traffic/TrafficOverviewMapper.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20336      +/-   ##
==========================================
- Coverage   40.19%   40.18%   -0.02%     
==========================================
  Files        1476     1476              
  Lines       68206    68235      +29     
  Branches    11317    11319       +2     
==========================================
+ Hits        27416    27417       +1     
- Misses      38281    38309      +28     
  Partials     2509     2509              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irfano irfano requested a review from staskus March 1, 2024 15:39
@irfano
Copy link
Member

irfano commented Mar 1, 2024

@staskus, I can't reproduce the issue of "Weekly and yearly bar chart bars start above 0" on trunk. Can you retest it on trunk and confirm if it has been resolved in this PR?

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@irfano
Copy link
Member

irfano commented Mar 1, 2024

I'm merging this PR, but I'm unsure if this PR has fixed #20311. If we reproduce it again, we can reopen the issue.

@irfano irfano merged commit 6a24dff into trunk Mar 1, 2024
19 checks passed
@irfano irfano deleted the Stats-Traffic-Fix-graph-issues branch March 1, 2024 16:17
@staskus
Copy link
Contributor

staskus commented Mar 1, 2024

@irfano, thanks for reminding! Just tested it, not reproducible anymore.

@irfano irfano added the Stats label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants