-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats traffic fix graph issues #20336
Conversation
Fix for week, and year bars starting above zero.
Created a separate TrafficBarChartItem to avoid collision with detail views bar chart
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20336 +/- ##
==========================================
- Coverage 40.19% 40.18% -0.02%
==========================================
Files 1476 1476
Lines 68206 68235 +29
Branches 11317 11319 +2
==========================================
+ Hits 27416 27417 +1
- Misses 38281 38309 +28
Partials 2509 2509 ☔ View full report in Codecov by Sentry. |
@staskus, I can't reproduce the issue of "Weekly and yearly bar chart bars start above 0" on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
I'm merging this PR, but I'm unsure if this PR has fixed #20311. If we reproduce it again, we can reopen the issue. |
@irfano, thanks for reminding! Just tested it, not reproducible anymore. |
Fixes #
#20312
#20311
To Test:
Bar graph
Detail Views Graph
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.