Refactors Notes to Kotlin

[antonis]

Description

This PR:

1. Converts the Notes model to Kotlin
2. Removes unused code
3. Replaces getters with lazy initialisation to limit json queries
4. Removes synchronisation locks
5. Cleans up the code and adds Kotlin idioms when possible

---

To Test:

1. Open the notifications tab
2. Scroll/Open notifications
3. Like/Share notifications
4. Change between tabs
5. Verify that there are no changes in the behaviour of the app

---

Regression Notes

1. Potential unintended areas of impact

   • Notifications

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual testing

3. What automated tests I added (or what prevented me from doing so)

   • None at this stage

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[dangermattic]

	3 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	Class EnabledActions is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️	Class NoteTimeGroup is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20200-14c493d
	Commit	14c493d
	Direct Download	wordpress-prototype-build-pr20200-14c493d.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20200-14c493d
	Commit	14c493d
	Direct Download	jetpack-prototype-build-pr20200-14c493d.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

Attention: 222 lines in your changes are missing coverage. Please review.

Comparison is base (688940e) 40.13% compared to head (14c493d) 40.16%.

Files	Patch %	Lines
...src/main/java/org/wordpress/android/models/Note.kt	0.00%	221 Missing ⚠️
...wordpress/android/datasets/NotificationsTable.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                         Coverage Diff                          @@
##           feature/notifications_refresh_p1   #20200      +/-   ##
====================================================================
+ Coverage                             40.13%   40.16%   +0.02%     
====================================================================
  Files                                  1470     1470              
  Lines                                 67837    67787      -50     
  Branches                              11238    11240       +2     
====================================================================
  Hits                                  27228    27228              
+ Misses                                38112    38062      -50     
  Partials                               2497     2497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mkevins]

Thank you for tackling this! I've taken an early look while it is still in draft, and left a few comments. Please don't consider the suggestions as necessary for this Kotlinization PR, though, since the diff is already very large. With such a large class, it may make more sense to take a few steps toward migrating it.

[mkevins]

From what I could tell, we the current synchronized code doesn't require reentrancy. I wonder whether we could use a Mutex here instead? 🤔

[antonis]

I experimented a bit with using Mutex but this would require introducing coroutines and changes outside the scope of the Note model. Tbh I'm not sure if locking is needed in all cases when accessing the json object 🤔

[jarvislin]

@antonis Thank you for converting the Note class to Kotlin. It's really helpful for us.
I've smoke tested the notification tab, the result is as expected, LGTM!