Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Issue post list tab switching #20184

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

AjeshRPai
Copy link
Contributor

@AjeshRPai AjeshRPai commented Feb 14, 2024

Fixes

This PR introduces a minor change to show the correct tabs when

  • user creates a new post from post list and press back to the post list
  • user publishes a post from drafts or from drafts → editor → publish

To Test:

  • Login to the Jetpack app/WP app
  • Go to Post list → publish tab or any other tab than Drafts
  • Create a post by clicking on Fab
  • Don't publish, Press back
  • Verify that you are re-directed to the Drafts tab
  • Select the post in Drafts tab
  • Publish the post
  • Verify that you are re-directed to publish tab

known issues

  • The tab selection change on trashing/deleting/moving a published post to draft is not implemented

Regression Notes

  1. Potential unintended areas of impact
    Tabs are not selected properly

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    NA


PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@AjeshRPai AjeshRPai requested review from zwarm and pantstamp February 14, 2024 10:27
@AjeshRPai AjeshRPai marked this pull request as ready for review February 14, 2024 10:27
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20184-81eb6e1
Commit81eb6e1
Direct Downloadjetpack-prototype-build-pr20184-81eb6e1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20184-81eb6e1
Commit81eb6e1
Direct Downloadwordpress-prototype-build-pr20184-81eb6e1.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2271079) 40.18% compared to head (81eb6e1) 40.17%.

Files Patch % Lines
...ordpress/android/ui/posts/PostListMainViewModel.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20184      +/-   ##
==========================================
- Coverage   40.18%   40.17%   -0.01%     
==========================================
  Files        1469     1469              
  Lines       67630    67634       +4     
  Branches    11200    11202       +2     
==========================================
  Hits        27174    27174              
- Misses      37964    37968       +4     
  Partials     2492     2492              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwarm zwarm self-assigned this Feb 14, 2024
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AjeshRPai. The correct tab is now selected. 👏

@zwarm zwarm merged commit 333c1c7 into trunk Feb 14, 2024
21 of 27 checks passed
@zwarm zwarm deleted the issue-post-list-tab-switching branch February 14, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants