-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications add tracks events for inline actions #20182
Notifications add tracks events for inline actions #20182
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mkevins 👍
The code looks good and the event is tracked as expected 🎉
🔵 Tracked: notifications_inline_action_tapped, Properties: {\"inline_action\":\"SharePostButtonTapped\"}"
I think the above is more simpler than the jpandroid_notification_row_share_action
from the spec (pc8HXX-1ua-p2) and can better support all the inline actions. I open a thread (p1707897223221329-slack-C06BWNSR02K) to update the spec with this approach.
Also left a suggestion for the detekt issue.
…/NotificationsListViewModel.kt Fixes detekt issue
…fications-add-tracks-event # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListViewModel.kt
4131e88
into
feature/notifications_refresh_p1
Fixes #20040
Description
This PR adds missing tracks events for notification inline actions. It should have been included in #20040, but it is written generally to address the tracking for all inline actions on notifications.
To Test:
Logcat:
Regression Notes
Notifications
Manual testing
More refactoring is needed to add unit tests.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: