-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the transient channel used for upload notification when notifications are disabled #20168
Create the transient channel used for upload notification when notifications are disabled #20168
Conversation
… prevent upload notification crash
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/24.2 #20168 +/- ##
================================================
- Coverage 40.21% 40.20% -0.01%
================================================
Files 1469 1469
Lines 67568 67584 +16
Branches 11191 11196 +5
================================================
Hits 27174 27174
- Misses 37902 37918 +16
Partials 2492 2492 ☔ View full report in Codecov by Sentry. |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work fixing this Antonis! The code makes sense (thanks for leaving a comment about the rationale for the version specific logic).
I tested this on a Pixel 3a (emulated device) with API 33, first by reproducing the issue on release/24.2
via these steps, and then confirming that these changes fixed the issue. 👍
Fixes #18495
Description
This PR creates the transient notification channel used for upload notification events when notifications are disabled.
To Test:
shouldShowNotifications
method to returnfalse
(you ca use this patchdisablenotifications.patch)
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: