Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mark all as read functionality #20136

Conversation

jarvislin
Copy link
Contributor

@jarvislin jarvislin commented Feb 7, 2024

Implement #20066

This is a feature about marking notifications as read in the current tab.


To Test:

  1. Open the Jetpack app and switch to the notifications tab.
  2. Scroll the top tab to LIKES and click it.
  3. Click the overflow icon at the top-right corner.
  4. Click the option: Mark all as read.
  5. It should mark all notifications as read in LIKES tab.
  6. Scroll the top tab to COMMENTS and click it.
  7. Click the overflow icon at the top-right corner.
  8. Click the option: Mark all as read.
  9. It should mark all notifications as read in COMMENTS tab.
  10. Done, thank you!

Regression Notes

  1. Potential unintended areas of impact

    • Notification tab
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual
  3. What automated tests I added (or what prevented me from doing so)

    • None

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@jarvislin jarvislin marked this pull request as ready for review February 7, 2024 03:49
@jarvislin jarvislin requested review from mkevins and antonis February 7, 2024 03:49
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20136-ac8c93e
Commitac8c93e
Direct Downloadwordpress-prototype-build-pr20136-ac8c93e.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20136-ac8c93e
Commitac8c93e
Direct Downloadjetpack-prototype-build-pr20136-ac8c93e.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (3704986) 40.40% compared to head (ac8c93e) 40.39%.
Report is 527 commits behind head on feature/notifications_refresh_p1.

Files Patch % Lines
...oid/ui/notifications/NotificationsListViewModel.kt 0.00% 12 Missing ⚠️
.../ui/notifications/NotificationsListFragmentPage.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           feature/notifications_refresh_p1   #20136      +/-   ##
====================================================================
- Coverage                             40.40%   40.39%   -0.01%     
====================================================================
  Files                                  1454     1454              
  Lines                                 66933    66946      +13     
  Branches                              11049    11050       +1     
====================================================================
  Hits                                  27043    27043              
- Misses                                37392    37405      +13     
  Partials                               2498     2498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonis antonis linked an issue Feb 7, 2024 that may be closed by this pull request
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @jarvislin 👍
The code looks good and works as expected in my tests 🎉

Dark theme RTL
Screenshot_20240207_121456 Screenshot_20240207_121423

@antonis antonis merged commit 1f17263 into feature/notifications_refresh_p1 Feb 7, 2024
27 of 28 checks passed
@antonis antonis deleted the issue/20066-add-Mark-all-as-read-functionality branch February 7, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤖 Add Mark all as read functionality
4 participants