-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mark all as read functionality #20136
Add mark all as read functionality #20136
Conversation
Generated by 🚫 Danger |
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/notifications_refresh_p1 #20136 +/- ##
====================================================================
- Coverage 40.40% 40.39% -0.01%
====================================================================
Files 1454 1454
Lines 66933 66946 +13
Branches 11049 11050 +1
====================================================================
Hits 27043 27043
- Misses 37392 37405 +13
Partials 2498 2498 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @jarvislin 👍
The code looks good and works as expected in my tests 🎉
Dark theme | RTL |
---|---|
1f17263
into
feature/notifications_refresh_p1
Implement #20066
This is a feature about marking notifications as read in the current tab.
To Test:
LIKES
and click it.Mark all as read
.LIKES
tab.COMMENTS
and click it.Mark all as read
.COMMENTS
tab.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: