-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader IA] Refresh blogs count after subscribing/unsubscribing from search screen #20135
[Reader IA] Refresh blogs count after subscribing/unsubscribing from search screen #20135
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected when following the testing steps precisely. Initially, I overlooked the three-dots menu in the bottom-right corner of the results list. Instead, I tapped on the blog to open an article and attempted to subscribe from there, which led to the pill not updating correctly upon returning to the feed.
Here are the steps:
- Search for a blog; for example, use "wec".
- In the results list, tap on an article.
- Subscribe to the blog.
- Return to the Reader feed; the blog count should now reflect the new subscription.
I'm fine if you want to merge this PR and open a new ticket for it, since I guess the fix may not be super easy to implement?
Thanks for the review, @daniloercoli Since we're targeting the release branch, I'll try to solve it in the same PR. I'll keep you posted. |
Generated by 🚫 dangerJS |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/24.2 #20135 +/- ##
================================================
- Coverage 40.22% 40.04% -0.18%
================================================
Files 1469 1460 -9
Lines 67556 67200 -356
Branches 11183 11141 -42
================================================
- Hits 27173 26910 -263
+ Misses 37894 37819 -75
+ Partials 2489 2471 -18 ☔ View full report in Codecov by Sentry. |
Update: we're handling the fix of the issue @daniloercoli found separately. I'll create the issue shortly. |
Issue created #20151 |
Fixes #20011
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
--
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: