-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lib] Update Tracks from 3.3 to 3.4 and update sentry gradle. #20134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found 1 violations: The PR caused the following dependency changes: +--- project :libs:analytics
-| \--- com.automattic:Automattic-Tracks-Android:3.3.0
-| +--- io.sentry:sentry-bom:6.18.1
-| | +--- io.sentry:sentry-android:6.18.1 (c)
-| | +--- io.sentry:sentry-android-fragment:6.18.1 (c)
-| | +--- io.sentry:sentry-android-okhttp:6.18.1 (c)
-| | +--- io.sentry:sentry-android-core:6.18.1 (c)
-| | +--- io.sentry:sentry-android-ndk:6.18.1 (c)
-| | \--- io.sentry:sentry:6.18.1 (c)
-| +--- io.sentry:sentry-android -> 6.18.1
-| | +--- io.sentry:sentry-android-core:6.18.1
-| | | +--- io.sentry:sentry:6.18.1
-| | | +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
-| | | +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2 (*)
-| | | \--- androidx.core:core:1.3.2 -> 1.10.0 (*)
-| | \--- io.sentry:sentry-android-ndk:6.18.1
-| | +--- io.sentry:sentry:6.18.1
-| | \--- io.sentry:sentry-android-core:6.18.1 (*)
-| +--- io.sentry:sentry-android-okhttp -> 6.18.1
-| | +--- io.sentry:sentry:6.18.1
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-| +--- io.sentry:sentry-android-fragment -> 6.18.1
-| | \--- io.sentry:sentry:6.18.1
-| +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0
-| | +--- com.squareup.okio:okio:3.2.0 -> 3.6.0
-| | | \--- com.squareup.okio:okio-jvm:3.6.0
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+| \--- com.automattic:Automattic-Tracks-Android:3.4.0
+| +--- io.sentry:sentry-bom:6.32.0
+| | +--- io.sentry:sentry-android:6.32.0 (c)
+| | +--- io.sentry:sentry-android-fragment:6.32.0 (c)
+| | +--- io.sentry:sentry-android-okhttp:6.32.0 (c)
+| | +--- io.sentry:sentry-android-core:6.32.0 (c)
+| | +--- io.sentry:sentry-android-ndk:6.32.0 (c)
+| | \--- io.sentry:sentry:6.32.0 (c)
+| +--- io.sentry:sentry-android -> 6.32.0
+| | +--- io.sentry:sentry-android-core:6.32.0
+| | | +--- io.sentry:sentry:6.32.0
+| | | +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
+| | | +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2 (*)
+| | | \--- androidx.core:core:1.3.2 -> 1.10.0 (*)
+| | \--- io.sentry:sentry-android-ndk:6.32.0
+| | +--- io.sentry:sentry:6.32.0
+| | \--- io.sentry:sentry-android-core:6.32.0 (*)
+| +--- io.sentry:sentry-android-okhttp -> 6.32.0
+| | +--- io.sentry:sentry:6.32.0
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+| +--- io.sentry:sentry-android-fragment -> 6.32.0
+| | \--- io.sentry:sentry:6.32.0
+| +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0
+| | +--- com.squareup.okio:okio:3.2.0 -> 3.6.0
+| | | \--- com.squareup.okio:okio-jvm:3.6.0
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-\--- com.automattic:Automattic-Tracks-Android:3.3.0 (*)
+\--- com.automattic:Automattic-Tracks-Android:3.4.0 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20134 +/- ##
===========================================
- Coverage 54.59% 40.23% -14.37%
===========================================
Files 14 1469 +1455
Lines 522 67597 +67075
Branches 52 11195 +11143
===========================================
+ Hits 285 27196 +26911
- Misses 219 37903 +37684
- Partials 18 2498 +2480 ☔ View full report in Codecov by Sentry. |
ravishanker
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19980
This PR updates two related sentry things. First tracks was updated here: Automattic/Automattic-Tracks-Android#195. This is necessary for the upcoming Android targetSdk update. Additionally the sentry gradle sdk also updated here. This simply ensures the sentry gradle plugin is aligned with the android sdk version.
To Test:
You'll need to edit code, so build manually. I used
EditPostActivity
and added the following code inonCreate
:Feel free to change the exception string so it's more unique to your test.
Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual test.
What automated tests I added (or what prevented me from doing so)
n/a
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.