Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lib] Update Tracks from 3.3 to 3.4 and update sentry gradle. #20134

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

notandyvee
Copy link
Contributor

@notandyvee notandyvee commented Feb 6, 2024

Fixes #19980


This PR updates two related sentry things. First tracks was updated here: Automattic/Automattic-Tracks-Android#195. This is necessary for the upcoming Android targetSdk update. Additionally the sentry gradle sdk also updated here. This simply ensures the sentry gradle plugin is aligned with the android sdk version.

To Test:

You'll need to edit code, so build manually. I used EditPostActivity and added the following code in onCreate:

        try {
            throw new Exception("This is a test.");
        } catch (Exception e) {
            final Map<String, String> tags = new HashMap<>();
            tags.put("tag", T.MAIN.name());
            mCrashLogging.sendReport(e, tags, "THIS IS A TEST ANDROID 14");
        }

Feel free to change the exception string so it's more unique to your test.

  • Ideally test with an Android 14 device.
  • Before building change the variant from debug to release. Necessary for Sentry to work.
  • Fire off the crash however you decide.
  • Check Sentry and find the exception. Should reflect fairly quickly.

Regression Notes

  1. Potential unintended areas of impact

    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    Manual test.

  3. What automated tests I added (or what prevented me from doing so)

    n/a


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:analytics
-|    \--- com.automattic:Automattic-Tracks-Android:3.3.0
-|         +--- io.sentry:sentry-bom:6.18.1
-|         |    +--- io.sentry:sentry-android:6.18.1 (c)
-|         |    +--- io.sentry:sentry-android-fragment:6.18.1 (c)
-|         |    +--- io.sentry:sentry-android-okhttp:6.18.1 (c)
-|         |    +--- io.sentry:sentry-android-core:6.18.1 (c)
-|         |    +--- io.sentry:sentry-android-ndk:6.18.1 (c)
-|         |    \--- io.sentry:sentry:6.18.1 (c)
-|         +--- io.sentry:sentry-android -> 6.18.1
-|         |    +--- io.sentry:sentry-android-core:6.18.1
-|         |    |    +--- io.sentry:sentry:6.18.1
-|         |    |    +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2 (*)
-|         |    |    \--- androidx.core:core:1.3.2 -> 1.10.0 (*)
-|         |    \--- io.sentry:sentry-android-ndk:6.18.1
-|         |         +--- io.sentry:sentry:6.18.1
-|         |         \--- io.sentry:sentry-android-core:6.18.1 (*)
-|         +--- io.sentry:sentry-android-okhttp -> 6.18.1
-|         |    +--- io.sentry:sentry:6.18.1
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-|         +--- io.sentry:sentry-android-fragment -> 6.18.1
-|         |    \--- io.sentry:sentry:6.18.1
-|         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0
-|         |    +--- com.squareup.okio:okio:3.2.0 -> 3.6.0
-|         |    |    \--- com.squareup.okio:okio-jvm:3.6.0
-|         |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
-|         |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
-|         |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
-|         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+|    \--- com.automattic:Automattic-Tracks-Android:3.4.0
+|         +--- io.sentry:sentry-bom:6.32.0
+|         |    +--- io.sentry:sentry-android:6.32.0 (c)
+|         |    +--- io.sentry:sentry-android-fragment:6.32.0 (c)
+|         |    +--- io.sentry:sentry-android-okhttp:6.32.0 (c)
+|         |    +--- io.sentry:sentry-android-core:6.32.0 (c)
+|         |    +--- io.sentry:sentry-android-ndk:6.32.0 (c)
+|         |    \--- io.sentry:sentry:6.32.0 (c)
+|         +--- io.sentry:sentry-android -> 6.32.0
+|         |    +--- io.sentry:sentry-android-core:6.32.0
+|         |    |    +--- io.sentry:sentry:6.32.0
+|         |    |    +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.6.2 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2 (*)
+|         |    |    \--- androidx.core:core:1.3.2 -> 1.10.0 (*)
+|         |    \--- io.sentry:sentry-android-ndk:6.32.0
+|         |         +--- io.sentry:sentry:6.32.0
+|         |         \--- io.sentry:sentry-android-core:6.32.0 (*)
+|         +--- io.sentry:sentry-android-okhttp -> 6.32.0
+|         |    +--- io.sentry:sentry:6.32.0
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+|         +--- io.sentry:sentry-android-fragment -> 6.32.0
+|         |    \--- io.sentry:sentry:6.32.0
+|         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+|         +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0
+|         |    +--- com.squareup.okio:okio:3.2.0 -> 3.6.0
+|         |    |    \--- com.squareup.okio:okio-jvm:3.6.0
+|         |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
+|         |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
+|         |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
+|         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-\--- com.automattic:Automattic-Tracks-Android:3.3.0 (*)
+\--- com.automattic:Automattic-Tracks-Android:3.4.0 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20134-8be4949
Commit8be4949
Direct Downloadjetpack-prototype-build-pr20134-8be4949.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20134-8be4949
Commit8be4949
Direct Downloadwordpress-prototype-build-pr20134-8be4949.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd1d1e9) 54.59% compared to head (8be4949) 40.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##            trunk   #20134       +/-   ##
===========================================
- Coverage   54.59%   40.23%   -14.37%     
===========================================
  Files          14     1469     +1455     
  Lines         522    67597    +67075     
  Branches       52    11195    +11143     
===========================================
+ Hits          285    27196    +26911     
- Misses        219    37903    +37684     
- Partials       18     2498     +2480     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravishanker ravishanker merged commit 7cb41dd into trunk Feb 11, 2024
21 of 29 checks passed
@ravishanker ravishanker deleted the andy/issue-19980 branch February 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Sentry so it supports targetSdk 34
3 participants