🤖 Use multiple avatars for multiple new likes or subscribers #20133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20133-7d29468 | |
| Commit | 7d29468 | |
| Direct Download | jetpack-prototype-build-pr20133-7d29468.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20133-7d29468 | |
| Commit | 7d29468 | |
| Direct Download | wordpress-prototype-build-pr20133-7d29468.apk |
antonis
force-pushed
the
issue/20039-notif-multiple-avatars
branch
from
9d9252b to
504e7d3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/notifications_refresh_p1 #20133 +/- ##
====================================================================
- Coverage 40.21% 40.20% -0.01%
====================================================================
Files 1468 1468
Lines 67536 67547 +11
Branches 11181 11184 +3
====================================================================
Hits 27157 27157
- Misses 37890 37901 +11
Partials 2489 2489 ☔ View full report in Codecov by Sentry. |
Generated by 🚫 Danger |
Generated by 🚫 dangerJS |
|
I've tweaked the dual avatar sizes and updated the alignment (ref p1707316051751449/1707227233.708549-slack-C06BWNSR02K) with 7d29468 |
mkevins
approved these changes
Feb 8, 2024
Comment on lines
+222
to
+235
| synchronized (mSyncLock) { | ||
| JSONArray bodyArray = mNoteJSON.optJSONArray("body"); | ||
| if (bodyArray != null && bodyArray.length() > 0) { | ||
| ArrayList<String> iconUrls = new ArrayList<>(); | ||
| for (int i = 0; i < bodyArray.length(); i++) { | ||
| String iconUrl = JSONUtils.queryJSON(bodyArray, "body[" + i + "].media[0].url", ""); | ||
| if (iconUrl != null && !iconUrl.isEmpty()) { | ||
| iconUrls.add(iconUrl); | ||
| } | ||
| } | ||
| return iconUrls; | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
This ad-hoc parsing seems reasonable for now, given that this whole file is due for refactoring to Room / FluxC (i.e. it likely isn't worth refactoring in piecemeal).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20039
Description
This PR adds multiple avatars for multiple post or comment likes and multiple subscribers
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist: