-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader IA] Simplify Reader Quick Start flow for new UX #20130
Conversation
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/24.2 #20130 +/- ##
=================================================
- Coverage 73.87% 54.59% -19.28%
=================================================
Files 9 14 +5
Lines 356 522 +166
Branches 42 52 +10
=================================================
+ Hits 263 285 +22
- Misses 75 219 +144
Partials 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @thomashorta . It's working as expected. LGTM
Fixes #20109
New message:
reader-ia-new-quickstart.mp4
To Test:
Make sure you're not already logged in.
You can also go through the steps in #20109 and verify it no longer happens since we don't try to move to Discover anymore and just stay on the selected Feed.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: