Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader IA] Simplify Reader Quick Start flow for new UX #20130

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

thomashorta
Copy link
Contributor

Fixes #20109

  • Remove unused code relative to the old top app bar and menu
  • Update the Quick Start flow to auto-complete upon showing Snackbar message
  • Update snackbar message for WP.com users to mention Subscriptions feed instead of Settings
  • No longer try to go to Discover feed when doing the quick start flow

New message:

Use Discover to find sites and tags. Try selecting Subscriptions to view subscribed content and manage your subscriptions.

reader-ia-new-quickstart.mp4

To Test:

Make sure you're not already logged in.

  1. Install and log into Jetpack
  2. Tap the option to go through onboarding, right after login
  3. Tap the onboarding card on My Site Dashboard ("Get to know the app")
  4. Tap "Connect with other sites"
  5. Verify the Reader icon is updated in the first snack bar message
  6. Verify tapping Reader shows a snackbar with the new message
  7. Go back to My Site
  8. Verify the onboarding task is considered completed

You can also go through the steps in #20109 and verify it no longer happens since we don't try to move to Discover anymore and just stay on the selected Feed.


Regression Notes

  1. Potential unintended areas of impact

    • Quick start flow issues
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing, unit testing
  3. What automated tests I added (or what prevented me from doing so)

    • Updated existing tests
    • Added tests for the new scenarios

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 6, 2024

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@thomashorta thomashorta added this to the 24.2 ❄️ milestone Feb 6, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 6, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.2 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 6, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20130-1828b60
Commit1828b60
Direct Downloadwordpress-prototype-build-pr20130-1828b60.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 6, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20130-1828b60
Commit1828b60
Direct Downloadjetpack-prototype-build-pr20130-1828b60.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc9d7c1) 73.87% compared to head (1828b60) 54.59%.
Report is 17 commits behind head on release/24.2.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/24.2   #20130       +/-   ##
=================================================
- Coverage         73.87%   54.59%   -19.28%     
=================================================
  Files                 9       14        +5     
  Lines               356      522      +166     
  Branches             42       52       +10     
=================================================
+ Hits                263      285       +22     
- Misses               75      219      +144     
  Partials             18       18               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @thomashorta . It's working as expected. LGTM :shipit:

@thomashorta thomashorta merged commit 818bd93 into release/24.2 Feb 6, 2024
20 checks passed
@thomashorta thomashorta deleted the issue/20109-reader-ia-quick-start branch February 6, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants