Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert notes adapter to kotlin #20129

Merged
merged 15 commits into from
Feb 6, 2024
Merged

Convert notes adapter to kotlin #20129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e0d8cf8
Remove unused methods
mkevins Feb 6, 2024
42f6414
Add nullability annotations
mkevins Feb 6, 2024
d2ec7a6
Use List sort in addAll
mkevins Feb 6, 2024
8be4ca2
Remove more dead code from notes adapter
mkevins Feb 6, 2024
8319f2f
Apply automatic Kotlin conversion to NotesAdapter
mkevins Feb 6, 2024
2a37563
Fix addAll sort after Kotlin conversion
mkevins Feb 6, 2024
bb2d84a
Add missing else clause to when
mkevins Feb 6, 2024
fe0d2db
Simplify null checks in viewholder init
mkevins Feb 6, 2024
818a70b
Remove else from exhaustive when
mkevins Feb 6, 2024
b365498
Mark notes adapter as deprecated at the file level
mkevins Feb 6, 2024
a48cc3b
Fix reference to buildFilteredNotesList
mkevins Feb 6, 2024
f240059
Suppress lint issues in notes adapter
mkevins Feb 6, 2024
3c02ee2
Rename notes adapter members
mkevins Feb 6, 2024
1a729ca
Update Kotlin code to clean up else ifs
mkevins Feb 6, 2024
d2c57d3
Simplify isUnread logic for note visibility
mkevins Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ess/src/main/java/org/wordpress/android/ui/notifications/NotificationsDetailActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ private NotificationDetailFragmentAdapter buildNoteListAdapterAndSetPosition(Not
ArrayList<Note> filteredNotes = new ArrayList<>();

// apply filter to the list so we show the same items that the list show vertically, but horizontally
NotesAdapter.buildFilteredNotesList(filteredNotes, notes, filter);
NotesAdapter.Companion.buildFilteredNotesList(filteredNotes, notes, filter);
adapter = new NotificationDetailFragmentAdapter(getSupportFragmentManager(), filteredNotes);

if (mBinding != null) {
Expand Down
Loading
Loading