-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 24.2 code freeze to trunk #20128
Conversation
…t to detect if subscriptions should be refreshed
…ge blogs and tags screen
…er feed from manage blogs and tags screen
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
…ng-tag-update-filter-pill [Reader IA] Subscribing to tag doesn't update the chip count
…-quick-start [Reader IA] Simplify Reader Quick Start flow for new UX
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #20128 +/- ##
===========================================
- Coverage 54.59% 40.22% -14.38%
===========================================
Files 14 1469 +1455
Lines 522 67556 +67034
Branches 52 11183 +11131
===========================================
+ Hits 285 27173 +26888
- Misses 219 37894 +37675
- Partials 18 2489 +2471 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
versionName
rc
number andversionCode
bumps inversion.properties
-
string.xml
updates
Notice that unfortunately (or luckily, depending on how one looks at it) this code freeze sat idle in the PR queue for a day or so, resulting in new PRs landing in the release branch since opening it. This made the commits list a bit confusing (what's with the commit on the branch before the version bump?! ah! they are the commits from the feature branches that went from pointing to trunk to pointing to the release branch)
This turned out to be an advantage, though, because there have been some strings changes, see also p1707227033739459-slack-CC7L49W13. I haven't checked the Fastfile, but I'm pretty sure Android works like iOS and we'll need to run a command locally to update strings.xml
. So, really, this will save us having to send two new strings notifications to the translators with the GlotPress automation 😄
@spencertransier I'm going to request changes to make sure the PR is merged only with the correct up-to-date strings.xml
. Feel free to dismiss if I've missed something.
Sorry, I would find and run the automation myself, but I just run out of time and gotta do school drop off 🏃♂️ |
@mokagio I updated the frozen |
No description provided.