-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/19952 update traffic tab by granularity #20125
Issue/19952 update traffic tab by granularity #20125
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #20125 +/- ##
==========================================
+ Coverage 40.10% 40.26% +0.15%
==========================================
Files 1458 1467 +9
Lines 67150 67539 +389
Branches 11129 11174 +45
==========================================
+ Hits 26933 27195 +262
- Misses 37737 37846 +109
- Partials 2480 2498 +18 ☔ View full report in Codecov by Sentry. |
The tabs are all working fine as before without feature flag enabled. With feature flag enabled, on Traffic tab, selecting By week, or By month, By year, then go back to By day seems to be not refreshing. Only Today card is being displayed, and rest of them are not showing up or stuck flickering. However after switching a few times across Insights, and Traffic tabs. It seems to be working fine. You can address that in separate PRs while doing graphs perhaps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
See the comment about cycling through Spinner options first time.
Thank you for the test, @ravishanker. I was able to reproduce it after changing the spinner more than 10 times. I will address it in this PR after the support rotation. |
@ravishanker, I was able to reproduce the bug occasionally, but also after changing the selected granularity and date. It has been fixed with my last commit. Could you please test it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now. LGTM 👍
Fixes #19952
This PR handles everything related to the new Traffic tab and the granularity spinner.
To Test:
Enable
stats_traffic_tab
flagRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: