Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/19952 update traffic tab by granularity #20125

Merged
merged 7 commits into from
Feb 12, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Feb 5, 2024

Fixes #19952

This PR handles everything related to the new Traffic tab and the granularity spinner.


To Test:

Enable stats_traffic_tab flag

  1. Log in.
  2. Navigate to Stats.
  3. Check the TRAFFIC and INSIGHTS tabs and all the detail screens on the stats. Compare the data from the web.
  4. Change the granularity spinner and selected date to different values. Compare the data from the web.
  5. Pull to refresh on all screens. Verify the data is still accurate. (If you want to go deep in testing, change the data by increasing the comment, like, view counts manually before updating)

Regression Notes

  1. Potential unintended areas of impact

    • All screens on stats
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Tested manually
  3. What automated tests I added (or what prevented me from doing so)

    • Updated StatsDateSelector

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20125-70e624a
Commit70e624a
Direct Downloadwordpress-prototype-build-pr20125-70e624a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20125-70e624a
Commit70e624a
Direct Downloadjetpack-prototype-build-pr20125-70e624a.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (1b865d8) 40.10% compared to head (70e624a) 40.26%.
Report is 77 commits behind head on trunk.

Files Patch % Lines
...droid/ui/stats/refresh/lists/StatsListViewModel.kt 0.00% 36 Missing ⚠️
.../android/ui/stats/refresh/lists/BaseListUseCase.kt 0.00% 7 Missing ⚠️
...sh/lists/sections/granular/SelectedDateProvider.kt 0.00% 1 Missing ⚠️
...ndroid/ui/stats/refresh/utils/StatsDateSelector.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20125      +/-   ##
==========================================
+ Coverage   40.10%   40.26%   +0.15%     
==========================================
  Files        1458     1467       +9     
  Lines       67150    67539     +389     
  Branches    11129    11174      +45     
==========================================
+ Hits        26933    27195     +262     
- Misses      37737    37846     +109     
- Partials     2480     2498      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravishanker
Copy link
Contributor

The tabs are all working fine as before without feature flag enabled.

With feature flag enabled, on Traffic tab, selecting By week, or By month, By year, then go back to By day seems to be not refreshing. Only Today card is being displayed, and rest of them are not showing up or stuck flickering. However after switching a few times across Insights, and Traffic tabs. It seems to be working fine.

You can address that in separate PRs while doing graphs perhaps!

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

See the comment about cycling through Spinner options first time.

@irfano
Copy link
Member Author

irfano commented Feb 6, 2024

Thank you for the test, @ravishanker. I was able to reproduce it after changing the spinner more than 10 times. I will address it in this PR after the support rotation.

@irfano irfano requested a review from ravishanker February 11, 2024 16:41
@irfano
Copy link
Member Author

irfano commented Feb 11, 2024

@ravishanker, I was able to reproduce the bug occasionally, but also after changing the selected granularity and date. It has been fixed with my last commit. Could you please test it again?

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now. LGTM 👍

@ravishanker ravishanker merged commit 819fa49 into trunk Feb 12, 2024
21 checks passed
@ravishanker ravishanker deleted the issue/19952-update-traffic-tab-by-granularity branch February 12, 2024 00:21
@irfano irfano added the Stats label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create or update date picker strip
3 participants