Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an overflow menu in Notifications #20124

Merged

Conversation

jarvislin
Copy link
Contributor

@jarvislin jarvislin commented Feb 5, 2024

Fixes #20065

This PR contains:

  1. An overflow menu icon in Notifications tab.
  2. A popup window for Notification actions.
  3. Two events added.

To Test:

  1. Open the Jetpack app and switch to the notifications tab.
  2. Click the overflow icon on the top-right corner
  3. It should show a popup window with two options.
  1. The UI of the popup window should match the new design. (See: yWt5gg3nWORhu079Qfv3mS-fi-51_3817)
  2. Switch to the dark/light theme to see the color works in two themes. Known issue: the shadow is not prominent enough in dark mode.
  3. Validate new events.
  4. Done, thank you!

Regression Notes

  1. Potential unintended areas of impact

    • Notifications tab
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual
  3. What automated tests I added (or what prevented me from doing so)

    • None

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20124-7903409
Commit7903409
Direct Downloadwordpress-prototype-build-pr20124-7903409.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20124-7903409
Commit7903409
Direct Downloadjetpack-prototype-build-pr20124-7903409.apk
Note: Google Login is not supported on these builds.

@jarvislin jarvislin requested review from mkevins and antonis February 6, 2024 04:42
@jarvislin jarvislin marked this pull request as ready for review February 6, 2024 04:42
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on a Pixel 3a (physical device), and it is working as described. I also noted the missing shadow in dark mode, but I agree it is not a blocker for this PR. The code also looks good.

Nice work Jarvis!

@jarvislin jarvislin merged commit 6964d59 into feature/notifications_refresh_p1 Feb 6, 2024
20 checks passed
@jarvislin jarvislin deleted the issue/20065-overflow-menu branch February 6, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants