Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader IA] Subscribing to tag doesn't update the chip count #20113

Merged

Conversation

RenanLukas
Copy link
Contributor

@RenanLukas RenanLukas commented Feb 2, 2024

Fixes #20012


To Test

  1. Install Jetpack and sign in;
  2. Open Reader;
  3. Open the drop-down menu and tap on Subscriptions feed;
  4. Tap the tags pill;
  5. Subscribe to a tag;
  6. Go back to reach the Subscriptions feed again
  7. Verify the number of tags is shown correctly
  8. Repeat steps 4-7 but this time unsubscribe from a tag.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    --


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Base automatically changed from feature/reader-ia to trunk February 3, 2024 18:10
@RenanLukas RenanLukas marked this pull request as ready for review February 5, 2024 04:19
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 5, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20113-16cae76
Commit16cae76
Direct Downloadjetpack-prototype-build-pr20113-16cae76.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20113-16cae76
Commit16cae76
Direct Downloadwordpress-prototype-build-pr20113-16cae76.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad69dd1) 40.28% compared to head (16cae76) 40.17%.
Report is 27 commits behind head on release/24.2.

Files Patch % Lines
...ress/android/ui/reader/ReaderActivityLauncher.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/24.2   #20113      +/-   ##
================================================
- Coverage         40.28%   40.17%   -0.12%     
================================================
  Files              1467     1453      -14     
  Lines             67506    66985     -521     
  Branches          11171    11119      -52     
================================================
- Hits              27196    26911     -285     
+ Misses            37812    37594     -218     
+ Partials           2498     2480      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniloercoli
Copy link
Contributor

Unfortunately, the tag count does not update immediately when I subscribe to a new tag. As shown in the recording, the count only changes from 16 to 17 tags after I initiate a manual pull-to-refresh.

screen-20240205-103625.mp4

@RenanLukas
Copy link
Contributor Author

Thanks for the review, @daniloercoli 👍

After some trial and error I think I've managed to make the behavior of adding a new tag to be exactly like iOS, which means the latest added tag won't be shown as selected when you navigate from manage blogs & tags screen back to the feed.

Screen.Recording.2024-02-05.at.6.40.22.PM.mov

It seems like this change have fixed the issue you were facing, but please let me know if it still continues to happen.

@RenanLukas RenanLukas added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Feb 5, 2024
@RenanLukas
Copy link
Contributor Author

I've added Do not merge until I confirm what should be the correct target branch.

@RenanLukas RenanLukas changed the base branch from trunk to release/24.2 February 5, 2024 23:13
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM!

@RenanLukas RenanLukas removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Feb 6, 2024
@RenanLukas
Copy link
Contributor Author

Merging to release/24.2. See p1707227033739459-slack-CC7L49W13

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@RenanLukas RenanLukas merged commit eb28864 into release/24.2 Feb 6, 2024
20 checks passed
@RenanLukas RenanLukas deleted the issue/20012-subscribing-tag-update-filter-pill branch February 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reader IA][Bug] Subscribing/Unsubscribing to a tag should auto-update tag filter pill in Subscriptions feed
4 participants