-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader IA] Subscribing to tag doesn't update the chip count #20113
[Reader IA] Subscribing to tag doesn't update the chip count #20113
Conversation
…t to detect if subscriptions should be refreshed
…ge blogs and tags screen
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/24.2 #20113 +/- ##
================================================
- Coverage 40.28% 40.17% -0.12%
================================================
Files 1467 1453 -14
Lines 67506 66985 -521
Branches 11171 11119 -52
================================================
- Hits 27196 26911 -285
+ Misses 37812 37594 -218
+ Partials 2498 2480 -18 ☔ View full report in Codecov by Sentry. |
Unfortunately, the tag count does not update immediately when I subscribe to a new tag. As shown in the recording, the count only changes from 16 to 17 tags after I initiate a manual pull-to-refresh. screen-20240205-103625.mp4 |
…er feed from manage blogs and tags screen
Thanks for the review, @daniloercoli 👍 After some trial and error I think I've managed to make the behavior of adding a new tag to be exactly like iOS, which means the latest added tag won't be shown as selected when you navigate from manage blogs & tags screen back to the feed. Screen.Recording.2024-02-05.at.6.40.22.PM.movIt seems like this change have fixed the issue you were facing, but please let me know if it still continues to happen. |
I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. LGTM!
Merging to |
Generated by 🚫 dangerJS |
Fixes #20012
To Test
Subscriptions
feed;Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
--
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: