Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Monitor: Adjust position in menu item #20098

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Feb 1, 2024

This PR moves the "Site Monitoring" menu item to below the last manage item (activity log, backup or scan - which is dependent on site capabilities)

See p1706783341392669-slack-C06EFHCP0PN

Before After
Alt desc Alt desc

Note: Only 1 Reviewer is needed


To Test:

  • Install and launch the app
  • Login with an account that has a creator plan
  • Navigate to My Site > More
  • ✅ Verify the Site Monitoring item is shown after the other manage items (activity log, backup, & scan)

Regression Notes

  1. Potential unintended areas of impact: Site monitoring row doesn't show
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Updated unit tests
  3. What automated tests I added (or what prevented me from doing so) N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@zwarm zwarm added this to the 24.2 milestone Feb 1, 2024
@zwarm zwarm requested review from pantstamp and AjeshRPai February 1, 2024 13:31
@zwarm zwarm self-assigned this Feb 1, 2024
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.2. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20098-f612aac
Commitf612aac
Direct Downloadwordpress-prototype-build-pr20098-f612aac.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20098-f612aac
Commitf612aac
Direct Downloadjetpack-prototype-build-pr20098-f612aac.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c886c3) 40.42% compared to head (f612aac) 40.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #20098   +/-   ##
=======================================
  Coverage   40.42%   40.42%           
=======================================
  Files        1455     1455           
  Lines       66970    66970           
  Branches    11053    11053           
=======================================
  Hits        27072    27072           
  Misses      37400    37400           
  Partials     2498     2498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AjeshRPai AjeshRPai merged commit 6621e43 into trunk Feb 2, 2024
20 of 25 checks passed
@AjeshRPai AjeshRPai deleted the issue/site-monitoring-move-menu-item branch February 2, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants