Notifications Refresh (Phase 1) #20072

antonis · 2024-01-30T06:23:45Z

Subtasks

List UI

Inline Actions

Navigation bar

To Test:

Use the test instructions of each PR to test the feature as a whole.
Also check

Test List UI changes: pdcxQM-39Z-p2
Navigation Bar and Inline Changes: pdcxQM-3a7-p2

Regression Notes

Potential unintended areas of impact
- Notifications tab and push notifacations
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- NotificationsListViewModelTest, NotificationHelperTest

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

…atar-notifi-icons Deprecates old in-line notification icons

dangermattic · 2024-01-30T06:24:13Z

	11 Warnings
⚠️	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	Class `EnabledActions` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `NoteTimeGroup` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `Notification` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `PostLike` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `NoteType` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `LinearLayoutManagerWrapper` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `InlineActionEvent` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `SharePostButtonTapped` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `Filter` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by 🚫 Danger

wpmobilebot · 2024-01-30T06:40:10Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20072-7921f85
	Commit	`7921f85`
	Direct Download	`wordpress-prototype-build-pr20072-7921f85.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-01-30T06:42:10Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20072-7921f85
	Commit	`7921f85`
	Direct Download	`jetpack-prototype-build-pr20072-7921f85.apk`

Note: Google Login is not supported on these builds.

…ion-heading-style Update the heading style

…tification-rows Update notification rows

Update read/unread status indication

…ormance

Adds notifications list tests

…-state # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListViewModel.kt

Fix issues related to the Like state in notifications tab

There is no value in the inner `PostNotification` class now (which should probably have been a sealed interface anyway).

…-reblog-notification 🤖 Remove deprecated reblog notification type

…-blink 🤖 Fixes comment like blinking

jarvislin

I only encountered #20308 during my manual test.
Other features are working as expected.

…ack from details view

…is-not-refreshed-after-a-mark-all-as-read-action The list is not refreshed after a mark all as read action

antonis · 2024-02-28T10:23:55Z

I only encountered #20308 during my manual test.

Thank you for testing and the fix @jarvislin 🙇
I'll proceed with merging as soon as the CI checks complete 🚀

mkevins

Tested this again, with the latest fix, and I did not observe any regressions. LGTM!

Antonis Lilis added 4 commits January 29, 2024 19:06

Removes notification utils and related resources

a484e36

Replaces BadgeImageView with a simple ImageView

d03c9e8

Removes unused dimension resources

487f92d

Merge pull request #20068 from wordpress-mobile/issue/20022-remove-av…

3e36513

…atar-notifi-icons Deprecates old in-line notification icons

antonis added Notifications [Type] Task Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels Jan 30, 2024

antonis added this to the 24.3 milestone Jan 30, 2024

antonis added [Status] Not Ready for Merge and removed Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels Jan 30, 2024

Jarvis Lin and others added 17 commits January 30, 2024 14:58

Update the heading style

b1814dc

Update the colors

e84df5f

Merge pull request #20073 from wordpress-mobile/issue/20020-notificat…

d04fdcf

…ion-heading-style Update the heading style

Update the rule of max lines

948bd1d

Remove the bold style from the title text of the notification

6a99d2f

Remove the dividers from the item of notification

17978c6

Remove the unused variable in the view holder

50928f4

Extract a function to fix a lint issue

f83dd45

Merge pull request #20076 from wordpress-mobile/issue/20021-update-no…

e7983e9

…tification-rows Update notification rows

Merge branch 'trunk' into feature/notifications_refresh_p1

8ec8dae

Adds green dot to indicate unread notification status

6d4bfb7

Fixes RTL unread dot alignement

bd45fe7

Merge pull request #20079 from wordpress-mobile/issue/20023-unread-notif

0ead1d9

Update read/unread status indication

Refactor the notifications item with ConstraintLayout for better perf…

931d6ba

…ormance

Extract dimens

3034da5

Add an action icon

31e0698

Handle the margin for the header of notifications item programmatically

60f764d

Jarvis Lin and others added 8 commits February 22, 2024 15:00

Sync UI state with each tab

b957aef

Remove a redundant import

8343191

Merge pull request #20223 from wordpress-mobile/task/notif-list-tests

f910976

Adds notifications list tests

Sync Like state of posts

ccde5ca

Merge branch 'feature/notifications_refresh_p1' into issue/20211-like…

abbfb83

…-state # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListViewModel.kt

Update tests

8e5dab4

Merge pull request #20243 from wordpress-mobile/issue/20211-like-state

bae97b0

Fix issues related to the Like state in notifications tab

Merge branch 'trunk' into feature/notifications_refresh_p1

1b9f91e

antonis requested review from mkevins and jarvislin February 22, 2024 09:58

Antonis Lilis and others added 6 commits February 22, 2024 17:41

Removes deprecated reblog notification type

6e3cfb0

Flatten Notification sealed class

6d68a12

There is no value in the inner `PostNotification` class now (which should probably have been a sealed interface anyway).

Rename Like to PostLike to more clearly distinguish from CommentLike

b0653b1

Merge pull request #20251 from wordpress-mobile/issue/20250-deprecate…

228ea88

…-reblog-notification 🤖 Remove deprecated reblog notification type

Merge branch 'trunk' into feature/notifications_refresh_p1

ccf7b69

Removes extra call to comment like status setter

11fd3a7

This was referenced Feb 23, 2024

[Notifications] Can't see share icon in dark mode #20285

Closed

🤖[Notifications] Sometimes user avatars don't load immediately #20286

Closed

Antonis Lilis and others added 4 commits February 26, 2024 08:33

Merge pull request #20263 from wordpress-mobile/fix/20248-commentlike…

b5af7bd

…-blink 🤖 Fixes comment like blinking

Merge branch 'trunk' into feature/notifications_refresh_p1

a01c8c2

Refresh the entire list because the differ doesn't handle correctly

55dc65c

Remove a unused import

ec12b06

jarvislin approved these changes Feb 28, 2024

View reviewed changes

Jarvis Lin and others added 3 commits February 28, 2024 17:45

Use notifyDataSetChanged() for preventing scroll to the top when we b…

d6788d0

…ack from details view

Merge pull request #20310 from wordpress-mobile/issue/20308-The-list-…

4dfa9cb

…is-not-refreshed-after-a-mark-all-as-read-action The list is not refreshed after a mark all as read action

Merge branch 'trunk' into feature/notifications_refresh_p1

7921f85

mkevins approved these changes Feb 28, 2024

View reviewed changes

antonis merged commit ff47667 into trunk Feb 28, 2024
20 checks passed

antonis deleted the feature/notifications_refresh_p1 branch February 28, 2024 10:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Notifications Refresh (Phase 1) #20072

Notifications Refresh (Phase 1) #20072

antonis commented Jan 30, 2024 •

edited

Loading

dangermattic commented Jan 30, 2024 •

edited

Loading

wpmobilebot commented Jan 30, 2024 •

edited

Loading

wpmobilebot commented Jan 30, 2024 •

edited

Loading

jarvislin left a comment

antonis commented Feb 28, 2024

mkevins left a comment

Notifications Refresh (Phase 1) #20072

Notifications Refresh (Phase 1) #20072

Conversation

antonis commented Jan 30, 2024 • edited Loading

Subtasks

List UI

Inline Actions

Navigation bar

Details View

Push notifications

Other

To Test:

Regression Notes

PR Submission Checklist:

UI Changes Testing Checklist:

dangermattic commented Jan 30, 2024 • edited Loading

wpmobilebot commented Jan 30, 2024 • edited Loading

wpmobilebot commented Jan 30, 2024 • edited Loading

jarvislin left a comment

Choose a reason for hiding this comment

antonis commented Feb 28, 2024

mkevins left a comment

Choose a reason for hiding this comment

antonis commented Jan 30, 2024 •

edited

Loading

dangermattic commented Jan 30, 2024 •

edited

Loading

wpmobilebot commented Jan 30, 2024 •

edited

Loading

wpmobilebot commented Jan 30, 2024 •

edited

Loading