-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch gutenberg-mobile's dependency group to org.wordpress #20042
Switch gutenberg-mobile's dependency group to org.wordpress #20042
Conversation
@oguzkocer I pushed part of these changes in #20005, it also updates the Gutenberg Mobile reference to an alpha version published to the new group ID. Once it's merged, I'll update this PR and we can proceed with merging. |
Done in a627298. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we should probably remove the following part:
WordPress-Android/.github/dependabot.yml
Lines 39 to 41 in a627298
# org.wordpress-mobile.gutenberg-mobile is deprecated and org.wordpress.gutenberg-mobile is used instead. | |
# Temporarily leaving this declaration during transition, but this should be removed soon. | |
- dependency-name: "org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge" |
WDYT?
@fluiddot Sure - feel free to make that change and then merge 👍 |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
This is a follow up to #19989 and makes the group id switch for
gutenberg-mobile
dependencies fromorg.wordpress-mobile
toorg.wordpress
.In order for this PR to build, gutenbergMobileVersion will need to be updated to a version that's published to the new group id. @fluiddot could you please take care of that? You can directly push to this branch and merge the PR once the CI is green.