Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch gutenberg-mobile's dependency group to org.wordpress #20042

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

oguzkocer
Copy link
Contributor

This is a follow up to #19989 and makes the group id switch for gutenberg-mobile dependencies from org.wordpress-mobile to org.wordpress.

In order for this PR to build, gutenbergMobileVersion will need to be updated to a version that's published to the new group id. @fluiddot could you please take care of that? You can directly push to this branch and merge the PR once the CI is green.

@oguzkocer oguzkocer added this to the 24.2 milestone Jan 25, 2024
@oguzkocer oguzkocer requested a review from fluiddot January 25, 2024 14:05
@fluiddot fluiddot mentioned this pull request Jan 25, 2024
12 tasks
@fluiddot
Copy link
Contributor

In order for this PR to build, gutenbergMobileVersion will need to be updated to a version that's published to the new group id. @fluiddot could you please take care of that? You can directly push to this branch and merge the PR once the CI is green.

@oguzkocer I pushed part of these changes in #20005, it also updates the Gutenberg Mobile reference to an alpha version published to the new group ID. Once it's merged, I'll update this PR and we can proceed with merging.

@fluiddot
Copy link
Contributor

@oguzkocer I pushed part of these changes in #20005, it also updates the Gutenberg Mobile reference to an alpha version published to the new group ID. Once it's merged, I'll update this PR and we can proceed with merging.

Done in a627298.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we should probably remove the following part:

# org.wordpress-mobile.gutenberg-mobile is deprecated and org.wordpress.gutenberg-mobile is used instead.
# Temporarily leaving this declaration during transition, but this should be removed soon.
- dependency-name: "org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge"

WDYT?

@oguzkocer
Copy link
Contributor Author

@fluiddot Sure - feel free to make that change and then merge 👍

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 26, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20042-cb4044e
Commitcb4044e
Direct Downloadjetpack-prototype-build-pr20042-cb4044e.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 26, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20042-cb4044e
Commitcb4044e
Direct Downloadwordpress-prototype-build-pr20042-cb4044e.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@oguzkocer oguzkocer merged commit 9796d17 into trunk Jan 26, 2024
21 checks passed
@oguzkocer oguzkocer deleted the switch/gutenberg-dependency-group-to-org.wordpress branch January 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants