Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 #20038

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 25, 2024

Bumps androidx.webkit:webkit from 1.7.0 to 1.10.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Jan 25, 2024
@dependabot dependabot bot requested review from a team and notandyvee and removed request for a team January 25, 2024 08:42
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 25, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20038-d68ade5
Commitd68ade5
Direct Downloadjetpack-prototype-build-pr20038-d68ade5.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 25, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20038-d68ade5
Commitd68ade5
Direct Downloadwordpress-prototype-build-pr20038-d68ade5.apk
Note: Google Login is not supported on these builds.

Bumps androidx.webkit:webkit from 1.7.0 to 1.10.0.

---
updated-dependencies:
- dependency-name: androidx.webkit:webkit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/androidx.webkit-webkit-1.10.0 branch from febc7db to d68ade5 Compare January 29, 2024 01:22
@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

-+--- androidx.webkit:webkit:1.7.0
++--- androidx.webkit:webkit:1.10.0
 \--- project :libs:editor
      \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.112.0-alpha3
           \--- org.wordpress.react-native-libraries.v4:react-native-webview:11.26.1
-               \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
+               \--- androidx.webkit:webkit:1.4.0 -> 1.10.0 (*)

Please review and act accordingly

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Contributor

@notandyvee notandyvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this through the support webview, which is what uses the webkit api. Correct me if I missed anything @ravishanker . I ran support and it worked.

I also took a look at the changes. I didn't see any potential breaking changes. The biggest change was 1.9.0. But no existing code is changed per the docs. Only adding to API.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ravishanker ravishanker added this to the 24.3 milestone Feb 13, 2024
@ravishanker ravishanker merged commit 2271079 into trunk Feb 13, 2024
21 of 24 checks passed
@ravishanker ravishanker deleted the dependabot/gradle/androidx.webkit-webkit-1.10.0 branch February 13, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: dependencies update PRs that update a dependency file, used by Dependabot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants