Move WordPress Analytics from GravatarApi to WPAndroid #19948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
maxme
commented
Jan 15, 2024
| @@ -689,7 +690,6 @@ class MeFragment : Fragment(R.layout.me_fragment), OnScrollToTopListener { | |||
| fun onEventMainThread(event: GravatarUploadFinished) { | |||
| binding?.showGravatarProgressBar(false) | |||
| if (event.success) { | |||
| AnalyticsTracker.track(ME_GRAVATAR_UPLOADED) | |||
There was a problem hiding this comment.
Just a note here, I removed this one because ME_GRAVATAR_UPLOADED is already tracked on line 676
maxme
commented
Jan 15, 2024
| AppLog.i(T.NUX, "Google avatar download and Gravatar upload failed."); | ||
| // FIXME: Don't track exceptions caused by poor internet connectivity |
There was a problem hiding this comment.
Previously some exceptions were ignored. I wasn't sure what to do, this could actually hide some underlying problems like a too short default timeout, so I decided to drop the filter.
There was a problem hiding this comment.
It looks better this way. We don't want to hide any exceptions, at least in the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes with the branch
gravatar/8-change-onerror-signatureTo Test:
Try to upload a new gravatar, use network throttler to generate timeout errors or proxy to generate other network issues.
Regression Notes
Potential unintended areas of impact
ME_GRAVATAR_UPLOAD_EXCEPTIONproperties have changed, but looking at the existing analytics, I think the changes are actually good, this will help to differentiate the different kinds of error. For details, the Gravatar backend is actually logging those.ME_GRAVATAR_UPLOAD_xxxare used in the Signup screen, I haven't changed that but the event name doesn't make sense there, we should maybe rename these events:GRAVATAR_UPLOAD_ERRORandGRAVATAR_UPLOAD_SUCCESS, this will have an impact on the history and if we do this change, we want to make sure WPiOS does the same.What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: