Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the value on the total followers card #19940

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Jan 14, 2024

Fixes #19893

This adds a feature to format the Total Followers card by

  • using comma for values greater than 999,
  • using suffixes ("M", "B" etc.) for values equal to or exceeding 1M.

The Total Followers card's behavior is now the same as other total cards.

before after after

To Test:

@guarani, I only request reviewing screenshots from you.

  1. Select a site with more than 999 followers.
  2. Navigate to My Site → Stats.
  3. If the Total Followers card is not visible on the INSIGHTS tab, add it from the ⚙️ icon at the top right.
  4. Verify the value on the Total Followers Card is shortened by using suffixes.
  5. Select a site with more than 999999 followers.
  6. Repeat 2-4.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Nothing
  3. What automated tests I added (or what prevented me from doing so)

    • None because I haven't added a new feature.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

`TotalFollowersUseCaseTest` has been updated to align with the changes made in the previous commit.
@irfano irfano requested review from ravishanker and guarani January 14, 2024 12:33
@irfano irfano added this to the 24.1 milestone Jan 14, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 14, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19940-8b49370
Commit8b49370
Direct Downloadwordpress-prototype-build-pr19940-8b49370.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 14, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19940-8b49370
Commit8b49370
Direct Downloadjetpack-prototype-build-pr19940-8b49370.apk
Note: Google Login is not supported on these builds.

Fix detekt line length issue
Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Fixed a line length detekt issue for build before merging.

@ravishanker ravishanker merged commit 758a87c into trunk Jan 14, 2024
19 checks passed
@ravishanker ravishanker deleted the issue/19893-format-value-on-total-followers-card branch January 14, 2024 22:47
@guarani
Copy link
Contributor

guarani commented Jan 15, 2024

It looks like this has already been reviewed and merged, but I gave it a quick test and it certainly looks fixed. Thanks Irfan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use thousands separator on Total Followers card
4 participants