[Tooling] Move Danger to GitHub Actions #19847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
from
9d3407a to
0b87434
Compare
iangmaia
added
the
Do Not Merge
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
from
0b87434 to
fde4fcb
Compare
iangmaia
added
Tooling
and removed
Do Not Merge
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
from
fde4fcb to
409f306
Compare
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19847-f26ac64 | |
| Commit | f26ac64 | |
| Direct Download | jetpack-prototype-build-pr19847-f26ac64.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19847-f26ac64 | |
| Commit | f26ac64 | |
| Direct Download | wordpress-prototype-build-pr19847-f26ac64.apk |
iangmaia
added
the
Do Not Merge
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
2 times, most recently
from
de0b5da to
c1ffc84
Compare
iangmaia
removed
the
Do Not Merge
oguzkocer
approved these changes
Jan 10, 2024
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
from
c1ffc84 to
f26ac64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR experiments moving the current Buildkite step setup to GitHub Actions (discussion on paaHJt-5Qn-p2).
Running on Buildkite is still an option, but it would require a GitHub action (or an intermediate server) to forward to Buildkite Pull Request Events such as "labeled", "unlabeled", "milestoned" and so on. This was implemented as a prototype on woocommerce/woocommerce-android#10385.
If we find problems using GitHub Actions, we can always revert this change and go back to Buildkite, as the setup works in general (just not as fast and as simple as GHA alone).
How to test
Make sure CI is green and Danger runs on labels/milestones/reviewers changes as well as on code changes.