Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: Dashboard UI #19771

Merged
merged 17 commits into from
Dec 14, 2023
Merged

Improvements: Dashboard UI #19771

merged 17 commits into from
Dec 14, 2023

Conversation

AjeshRPai
Copy link
Contributor

@AjeshRPai AjeshRPai commented Dec 12, 2023

Fixes

#19772

Description

This PR makes the following changes

  1. Removes the site info header from my site fragment - A SiteInfoHeaderCardViewHolder is added to render the site header instead of my site fragment. This will improve the rendering time and will also help us when converting the views to compose
  2. Fixes the background color in the compose cards
Before After
Screenshot 2023-12-07 at 6 59 17 PM Screenshot 2023-12-12 at 4 25 32 PM
  • Blaze Campaign
  • Bloganuary Nudge Card
  • Personalize card
  • Domain dashboard card
  1. Adds a haptic feedback to the bottom nav

To Test:

  1. Login to the Jetpack app
  2. Go to the dashboard
  3. Verify that the dashboard is rendered as before
  4. Verify that there are no background in compose cards
  5. Verify that on switching between the bottom nav items(my site, reader, notifications, me) , there is a haptic feedback

Regression Notes

  1. Potential unintended areas of impact
    N

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

# Conflicts:
#	WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapter.kt
#	WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 12, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19771-e383d9c
Commite383d9c
Direct Downloadwordpress-prototype-build-pr19771-e383d9c.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 12, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19771-e383d9c
Commite383d9c
Direct Downloadjetpack-prototype-build-pr19771-e383d9c.apk
Note: Google Login is not supported on these builds.

@AjeshRPai AjeshRPai requested a review from zwarm December 12, 2023 12:37
@AjeshRPai AjeshRPai marked this pull request as ready for review December 12, 2023 12:57
@AjeshRPai AjeshRPai changed the title Improvements: Dashboard UI Improvements: Dashboard UI Dec 12, 2023
@AjeshRPai AjeshRPai added this to the 24.0 milestone Dec 12, 2023
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ Class SiteInfoHeaderCardViewholder is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjeshRPai - so far, so good. The site header functions as normal (clicks on title, icon, launching the site selector). To my eye, I do not see the background color on cards, but in layout inspector I see the corners. Not sure if this should be the case or I am not testing it correctly.

Alt desc

@AjeshRPai
Copy link
Contributor Author

Hey @zwarm

To my eye, I do not see the background color on cards, but in layout inspector I see the corners. Not sure if this should be the case or I am not testing it correctly.

I think thats ok, can u also check if the cards built using XML also has corners. As much as I checked all cards has corners in layout inspector. So that's ok.

@zwarm
Copy link
Contributor

zwarm commented Dec 12, 2023

@AjeshRPai

I think thats ok, can u also check if the cards built using XML also has corners.

I checked XML and see the same corner , so 👍

@zwarm zwarm self-requested a review December 12, 2023 19:31
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjeshRPai - Adding my approval. Will wait for @osullivanchris to give the thumbs up before merging.

@AjeshRPai AjeshRPai merged commit 55b6e4b into trunk Dec 14, 2023
20 checks passed
@AjeshRPai AjeshRPai deleted the issue/ui-changes-to-dashboard branch December 14, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants