-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements: Dashboard UI #19771
Improvements: Dashboard UI #19771
Conversation
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapter.kt # WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AjeshRPai - so far, so good. The site header functions as normal (clicks on title, icon, launching the site selector). To my eye, I do not see the background color on cards, but in layout inspector I see the corners. Not sure if this should be the case or I am not testing it correctly.
Hey @zwarm
I think thats ok, can u also check if the cards built using XML also has corners. As much as I checked all cards has corners in layout inspector. So that's ok. |
I checked XML and see the same corner , so 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AjeshRPai - Adding my approval. Will wait for @osullivanchris to give the thumbs up before merging.
Fixes
#19772
Description
This PR makes the following changes
SiteInfoHeaderCardViewHolder
is added to render the site header instead of my site fragment. This will improve the rendering time and will also help us when converting the views to composeTo Test:
Regression Notes
Potential unintended areas of impact
N
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: