Support media deep links #19768
Merged
Support media deep links #19768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19768-61fc769 | |
| Commit | 61fc769 | |
| Direct Download | wordpress-prototype-build-pr19768-61fc769.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19768-61fc769 | |
| Commit | 61fc769 | |
| Direct Download | jetpack-prototype-build-pr19768-61fc769.apk |
…gIntentReceiverActivity
↑ Updates: the logic of navigating to media screen in WPMainActivity
- Removes: the logic of launching media from ActivityLauncher.java + Adds: the logic of launching media in ActivityNavigator.kt ↑ Updates: the logic in DeepLinkNavigator to use ActivityNavigator.kt
AjeshRPai
approved these changes
Dec 13, 2023
| override fun shouldHandleUrl(uri: UriWrapper): Boolean { | ||
| return (uri.host == HOST_WORDPRESS_COM && | ||
| uri.pathSegments.firstOrNull() == MEDIA_PATH) || uri.host == MEDIA_PATH | ||
| } |
There was a problem hiding this comment.
There was a typo in the MEDIA_PATH variable, I fixed it with the commit b0b034c
| android:host="wordpress.com" | ||
| android:pathPattern="/media/..*" | ||
| android:scheme="http" /> | ||
|
|
There was a problem hiding this comment.
That's weird ... we don't support .* for pages or stats or others.
| initSelectedSite(); | ||
| } | ||
| mActivityNavigator.viewCurrentBlogMedia(this, getSelectedSite()); | ||
| break; |
There was a problem hiding this comment.
Great idea - I forgot ActivityNavigator existed.
| @@ -114,5 +117,7 @@ class DeepLinkNavigator | |||
| object OpenLoginPrologue : NavigateAction() | |||
| data class OpenJetpackForDeepLink(val action: String?, val uri: UriWrapper) : NavigateAction() | |||
| object OpenJetpackStaticPosterView : NavigateAction() | |||
| data class OpenMediaForSite(val site: SiteModel) : NavigateAction() | |||
| object OpenMedia : NavigateAction() | |||
There was a problem hiding this comment.
Updated the logic to use ActivityNavigator here. Commit - 61fc769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for media deeplinks as a part of the Super fast media uploads
wordpress.com/media/{domain name}intent://media/#Intent;scheme=jetpack;package=com.jetpack.androidTo Test:
Preparing
test-media-links.html.zip
Testing the deep links
test-media-links.htmlin a browser on your deviceIntent Medialinkwordpress.com/medialinkwordpress.com/media/nonsenselinkwordpress.com/media/..for your domain linkRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist:N/A