[Upload] Add UploadService and UploadWorker logs #19762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 8, 2023 17:11
This one has a hardcoded value since, as the name implies, it is called from a few places but only from the Editor, which should be enough for the "source" identification.
Generated by 🚫 dangerJS |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19762-de66db5 | |
| Commit | de66db5 | |
| Direct Download | jetpack-prototype-build-pr19762-de66db5.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19762-de66db5 | |
| Commit | de66db5 | |
| Direct Download | wordpress-prototype-build-pr19762-de66db5.apk |
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to add more information for properly debugging the crash described in #18714 by adding some logs displaying the caller/source of the
UploadServicestart and whenUploadWorkeris used.Even though we should ideally move away from using services for uploading posts and media (as mentioned in #18714 (comment)), the real issue causing the crash is trying to start a foreground service from the background and without the information about the caller/source, it's being pretty challenging to understand which part of the code is trying to start such service from the background.
These logs should help us understand what is going on and aid us when we go ahead with refactoring the service to use only WorkManager.
To Test:
There are no specific instructions here, but you can try some app flows that result in
UploadServiceand/orUploadWorkerbeing called and verify that the logs are being shown accordingly.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.