Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Following Sites list is incomplete #13989

Closed
reginabally opened this issue Feb 8, 2021 · 11 comments · Fixed by #20430
Closed

Reader: Following Sites list is incomplete #13989

reginabally opened this issue Feb 8, 2021 · 11 comments · Fixed by #20430

Comments

@reginabally
Copy link

It was reported in 3719482-zen that the user can only see the number of followed site is 98 on the app but they've followed more than that. According to the Subscriptions Admin, the user has followed a total of 172 sites.

The issue was previously reported in the WPiOS app here.

Expected behavior

We'd expect to be able to view and manage all of the sites that we followed on the Reader in the app.

Actual behavior

The total number of followed sites has a lesser number show up in the Reader.

Steps to reproduce the behavior

  1. Follow more than 100 sites on WordPress.com Reader
  2. Go to Reader > Following, tap the "Filter" option
  3. See that the list of following sites is less than 100
Reported on Samsung SM-A217F, WPAndroid 16.5
@rossanafmenezes
Copy link
Contributor

User has provided a screenshot (in the ZD ticket). It shows 96 sites followed.

@designsimply
Copy link
Contributor

designsimply commented Feb 8, 2021

Tested and confirmed that that list of followed sites in Reader > Following > Filter > Sites as well as Reader > Following > Manage > Followed Sites are limited to 100 or less for an account that shows "480 Followed sites" at https://wordpress.com/following/manage.

Reader Filter Reader Manage
Screenshot_20210208-124713 Screenshot_20210208-124651

Tested with WPAndroid 16.6-rc-2 on Pixel 3 Android 11.

I'm actually surprised that you can find a count showing in the Filter bottom sheet but not in the Reader Manage section.

Suggested improvements for consideration:

  • Move the count from the Filters bottom sheet to the Reader Manage section and make it paginated there.
  • Show the 50 (or less?) latest site in the Filters bottom sheet with a link at the bottom of that list pointing back to Reader Manage.

Disclaimer: these are just my own personal suggestions.

@eduardozulian
Copy link

Another report in 3748173-zen

@reginabally
Copy link
Author

Another report in 3805269-zd-woothemes.

@reginabally
Copy link
Author

Another report in 3874312-zd-woothemes.

@zwarm
Copy link
Contributor

zwarm commented Apr 27, 2021

The endpoint /read/following/mine is called without paging parameters. After a quick review of wpcom-json-api-read-following-mine-v1-2-endpoint.php , I can confirm that paging is available using the “page=x” parameter. As previously noted, the max results is 100 per page and the endpoint will ignore any “number” param greater than 100. The results returned are ordered from newest; however Android is forcing an order by name in ReaderBlogTable.ReaderBlogList getFollowedBlogs(), so all paging results would be needed before sorting or the user experience would appear choppy.

The fetching logic happens in ReaderUpdateLogic.updateFollowedBlogs. Some thought needs to be given on implementation of multiple fetches with in the existing architecture. It might be best to split this logic similar to the way the new Discover feed was implemented; however in that instance we weren’t showing all the results at once. To help ease the transition to pages, I would suggest an update to the API to accept a “sort” parameter?

After my research (conducted during my groundskeeping rotation), I have come to a very similar conclusion as the WPiOS investigation. This is a larger effort that would best be treated as a project.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

@stale stale bot added the [Status] Stale label Apr 27, 2022
@thehenrybyrd
Copy link
Contributor

@reginabally @rossanafmenezes @eduardozulian are we continuing to see reports of this issue?

@eduardozulian
Copy link

I'm not actively working on mobile now so I can't confirm, @thehenrybyrd! I know you pinged Regina, but I also shared your message in mobile-support so others can chime in.

@reginabally
Copy link
Author

Hi @thehenrybyrd! Thanks for following up! I haven't come across new reports about this issue. But looking at the comment here, it seems like it's not a minor effort to fix this. Are we closing this because of inactivity (no newer reports) and low impact?

@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants