Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Subscribed Sites list is incomplete #20218

Closed
RenanLukas opened this issue Feb 20, 2024 · 4 comments
Closed

[Reader] Subscribed Sites list is incomplete #20218

RenanLukas opened this issue Feb 20, 2024 · 4 comments
Assignees

Comments

@RenanLukas
Copy link
Contributor

RenanLukas commented Feb 20, 2024

This issue and it's cause were discovered by @daniloercoli.

When the user has many blogs (probably > 100, see below) some of them won't be shown in the Subscriptions feed or Manage Tags & Blogs screen. This happens because paging is not handled (like it is on web client) in our implementation of the read/following/mine endpoint.

We have to implement paging in this endpoint, which includes adding number and page query parameters (see p1708454312137679/1708440747.970699-slack-C01CW1VMLAF).

This issue seems to be reproducible for users with > 100 subscribed blogs because 100 is probably the default value for number.

Warning

It's worth saying that besides the endpoint paging not being implemented we also limit the number of displayed posts in the client (see ReaderPostAdapter).

Expected behavior

All subscribed blogs are shown.

Actual behavior

Not all subscribed blogs are shown.

Steps to reproduce the behavior

1 - Subscribe to > 100 blogs;
2 - Open Reader;
3 - Select Subscriptions feed;
4 - Verify the subscribed blogs chip: the number is wrong (compare it with web);
5 - Open "Manage Tags & Blogs" screen: some blogs that the user is subscribed to are missing.

@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@daniloercoli
Copy link
Contributor

I suggest, as an initial implementation, to adopt the same approach as the Web Reader. They fetch all pages in the background until there are no more results. You can see it in action here https://wordpress.com/read/subscriptions and filter for following/mine in the nwetwork tab. (Ref: https://public-api.wordpress.com/rest/v1.2/read/following/mine?number=100&page=1).

@daniloercoli
Copy link
Contributor

Noticed that we already have another issue tracking the same problem: #13989

@daniloercoli daniloercoli changed the title [Reader] Subscribed blogs missing [Reader] Subscribed Sites list is incomplete Feb 28, 2024
@RenanLukas RenanLukas assigned RenanLukas and unassigned RenanLukas Mar 5, 2024
@daniloercoli daniloercoli self-assigned this Mar 7, 2024
@daniloercoli
Copy link
Contributor

Fixed in #20430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants