Fix broken unit tests

wordpress-mobile · Dec 8, 2023 · de66db5 · de66db5
1 parent 6d8ca46
commit de66db5
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 19 deletions.
diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/FeaturedImageHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/FeaturedImageHelperTest.kt
@@ -120,7 +120,7 @@ class FeaturedImageHelperTest {
         // Act
         val mediaModel = featuredImageHelper.retryFeaturedImageUpload(mock(), mock())
         // Assert
-        verify(uploadServiceFacade).uploadMedia(argThat { this[0] == mediaModel })
+        verify(uploadServiceFacade).uploadMedia(argThat { this[0] == mediaModel }, any())
     }
 
     @Test
@@ -189,7 +189,7 @@ class FeaturedImageHelperTest {
         // Act
         featuredImageHelper.queueFeaturedImageForUpload(0, createSiteModel(), mock(), "")
         // Assert
-        verify(uploadServiceFacade).uploadMedia(argThat { this[0] == mediaModel })
+        verify(uploadServiceFacade).uploadMedia(argThat { this[0] == mediaModel }, any())
     }
 
     @Test

diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/editor/StorePostViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/editor/StorePostViewModelTest.kt
@@ -8,6 +8,7 @@ import org.junit.Before
 import org.junit.Test
 import org.mockito.Mock
 import org.mockito.kotlin.any
+import org.mockito.kotlin.eq
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.verifyNoInteractions
 import org.mockito.kotlin.whenever
@@ -249,7 +250,7 @@ class StorePostViewModelTest : BaseUnitTest() {
         verify(savePostToDbUseCase).savePostToDb(postRepository, site)
         assertThat(result).isEqualTo(SAVED_ONLINE)
         verify(postUtils).trackSavePostAnalytics(postModel, site)
-        verify(uploadService).uploadPost(context, postId, isFirstTimePublish)
+        verify(uploadService).uploadPost(eq(context), eq(postId), eq(isFirstTimePublish), any())
     }
 
     @Test

diff --git a/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadStarterConcurrentTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadStarterConcurrentTest.kt
@@ -61,7 +61,8 @@ class UploadStarterConcurrentTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(draftPosts.size)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any()
         )
     }
 

diff --git a/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadStarterMutexTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadStarterMutexTest.kt
@@ -113,7 +113,7 @@ class UploadStarterMutexTest : BaseUnitTest() {
             .thenReturn(UploadActionUseCase.UploadAction.UPLOAD)
 
         // throw IllegalStateException when uploading post (emulate trying to start background service)
-        whenever(uploadServiceFacade.uploadPost(any(), any<PostModel>(), any()))
+        whenever(uploadServiceFacade.uploadPost(any(), any<PostModel>(), any(), any()))
             .thenThrow(IllegalStateException("FAKE: Not allowed to start service intent"))
 
         // ACT

diff --git a/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadStarterTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadStarterTest.kt
@@ -143,7 +143,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(draftPosts.size + draftPages.size)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -166,7 +167,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(0)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -188,7 +190,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(draftPosts.size + draftPages.size)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -211,7 +214,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(expectedUploadPostExecutions)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -241,7 +245,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(expectedUploadPostExecutions)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -283,7 +288,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(expectedUploadPostsAndPages.size)).uploadPost(
             context = any(),
             post = argWhere { expectedUploadPostsAndPages.contains(it) },
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
         verify(
             uploadServiceFacade,
@@ -315,7 +321,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, never()).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -333,7 +340,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, never()).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -351,7 +359,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(1)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -373,7 +382,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, never()).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -395,7 +405,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, times(1)).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -416,7 +427,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, never()).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -436,7 +448,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, never()).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }
 
@@ -463,7 +476,8 @@ class UploadStarterTest : BaseUnitTest() {
         verify(uploadServiceFacade, never()).uploadPost(
             context = any(),
             post = any(),
-            trackAnalytics = any()
+            trackAnalytics = any(),
+            sourceForLogging = any(),
         )
     }