Fix dark mode divider color in JetpackDropdownMenu

wordpress-mobile · Dec 12, 2023 · d43ea0e · d43ea0e
1 parent 97ad720
commit d43ea0e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/...ain/java/org/wordpress/android/ui/compose/components/menu/dropdown/JetpackDropdownMenu.kt b/...ain/java/org/wordpress/android/ui/compose/components/menu/dropdown/JetpackDropdownMenu.kt
@@ -14,7 +14,6 @@ import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import me.saket.cascade.CascadeDropdownMenu
@@ -47,7 +46,9 @@ fun JetpackDropdownMenu(menuItems: List<MenuElementData>, defaultItem: MenuEleme
                     is MenuElementData.Item -> Item(element, onMenuItemClick)
                 }
                 if (element.hasDivider) {
-                    Divider()
+                    Divider(
+                        color = itemDividerColor(),
+                    )
                 }
             }
         }

diff --git a/...ess/src/main/java/org/wordpress/android/ui/compose/components/menu/dropdown/MenuColors.kt b/...ess/src/main/java/org/wordpress/android/ui/compose/components/menu/dropdown/MenuColors.kt
@@ -1,11 +1,12 @@
 package org.wordpress.android.ui.compose.components.menu.dropdown
 
+import androidx.compose.material.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.graphics.Color
 import org.wordpress.android.ui.compose.theme.AppColor
 
 @Composable
-fun isLightTheme(): Boolean = androidx.compose.material.MaterialTheme.colors.isLight
+fun isLightTheme(): Boolean = MaterialTheme.colors.isLight
 
 @Composable
 fun itemContentColor(): Color = if (isLightTheme()) {
@@ -20,3 +21,10 @@ fun itemBackgroundColor(): Color = if (isLightTheme()) {
 } else {
     AppColor.DarkGray90
 }
+
+@Composable
+fun itemDividerColor(): Color = if (isLightTheme()) {
+    MaterialTheme.colors.onSurface.copy(alpha = 0.12f)
+} else {
+    AppColor.Gray50
+}