Skip to content

Commit

Permalink
Only initialize reader content fragment if it actually changed
Browse files Browse the repository at this point in the history
  • Loading branch information
Thomas Horta committed Feb 1, 2024
1 parent eeec540 commit ab48882
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,11 @@ class ReaderFragment : Fragment(R.layout.reader_fragment_layout), MenuProvider,
if (uiState.selectedReaderTag == null) {
return
}

// only initialize the fragment if it's not already initialized
val currentFragmentTag = childFragmentManager.findFragmentById(R.id.container)?.tag
if (currentFragmentTag == uiState.selectedReaderTag.tagSlug) return

childFragmentManager.beginTransaction().apply {
val fragment = if (uiState.selectedReaderTag.isDiscover()) {
ReaderDiscoverFragment()
Expand All @@ -243,7 +248,7 @@ class ReaderFragment : Fragment(R.layout.reader_fragment_layout), MenuProvider,
uiState.selectedReaderTag.isFilterable
)
}
replace(R.id.container, fragment)
replace(R.id.container, fragment, uiState.selectedReaderTag.tagSlug)
commit()
}
viewModel.uiState.value?.let {
Expand Down

0 comments on commit ab48882

Please sign in to comment.