Implement tracking for post resolution conflict overlay

wordpress-mobile · Apr 11, 2024 · 8089791 · 8089791
1 parent e71f620
commit 8089791
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListDialogHelper.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListDialogHelper.kt
@@ -138,7 +138,6 @@ class PostListDialogHelper(
     }
 
     fun showAutoSaveRevisionDialog(post: PostModel) {
-        analyticsTracker.track(UNPUBLISHED_REVISION_DIALOG_SHOWN, mapOf(POST_TYPE to "post"))
         localPostIdForAutosaveRevisionResolutionDialog = post.id
         if (isPostConflictResolutionEnabled) {
             showConflictResolutionOverlay?.invoke(
@@ -147,6 +146,7 @@ class PostListDialogHelper(
                 )
             )
         } else {
+            analyticsTracker.track(UNPUBLISHED_REVISION_DIALOG_SHOWN, mapOf(POST_TYPE to "post"))
             val dialogHolder = DialogHolder(
                 tag = CONFIRM_ON_AUTOSAVE_REVISION_DIALOG_TAG,
                 title = UiStringRes(R.string.dialog_confirm_autosave_title),
@@ -308,10 +308,6 @@ class PostListDialogHelper(
                 localPostIdForAutosaveRevisionResolutionDialog?.let {
                     // open the editor with the local post (don't use the auto save version)
                     editLocalPost(it)
-                    analyticsTracker.track(
-                        UNPUBLISHED_REVISION_DIALOG_LOAD_LOCAL_VERSION_CLICKED,
-                        mapOf(POST_TYPE to "post")
-                    )
                 }
             }
 
@@ -320,10 +316,6 @@ class PostListDialogHelper(
                     // open the editor with the restored auto save
                     localPostIdForAutosaveRevisionResolutionDialog = null
                     editRestoredAutoSavePost(it)
-                    analyticsTracker.track(
-                        UNPUBLISHED_REVISION_DIALOG_LOAD_UNPUBLISHED_VERSION_CLICKED,
-                        mapOf(POST_TYPE to "post")
-                    )
                 }
             }
         }

diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostResolutionOverlayUiState.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostResolutionOverlayUiState.kt
@@ -43,9 +43,9 @@ enum class PostResolutionType {
     AUTOSAVE_REVISION_CONFLICT
 }
 
-enum class PostResolutionConfirmationType {
-    CONFIRM_LOCAL,
-    CONFIRM_OTHER
+enum class PostResolutionConfirmationType(val analyticsLabel: String) {
+    CONFIRM_LOCAL("local_version"),
+    CONFIRM_OTHER("remote_version")
 }
 
 sealed class PostResolutionOverlayActionEvent {

diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostResolutionOverlayViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostResolutionOverlayViewModel.kt
@@ -15,7 +15,8 @@ import javax.inject.Inject
 
 class PostResolutionOverlayViewModel @Inject constructor(
     private val dateTimeUtilsWrapper: DateTimeUtilsWrapper,
-    private val dateUtilsWrapper: DateUtilsWrapper
+    private val dateUtilsWrapper: DateUtilsWrapper,
+    private val tracker: PostResolutionOverlayAnalyticsTracker
 ) : ViewModel() {
     private val _uiState = MutableLiveData<PostResolutionOverlayUiState>()
     val uiState: LiveData<PostResolutionOverlayUiState> = _uiState
@@ -42,6 +43,8 @@ class PostResolutionOverlayViewModel @Inject constructor(
         resolutionType = postResolutionType
         post = postModel
 
+        onDialogShown()
+
         val uiState = when (resolutionType) {
             PostResolutionType.SYNC_CONFLICT -> getUiStateForSyncConflict(postModel)
             PostResolutionType.AUTOSAVE_REVISION_CONFLICT -> getUiStateForAutosaveRevisionConflict(postModel)
@@ -133,26 +136,31 @@ class PostResolutionOverlayViewModel @Inject constructor(
     }
 
     private fun onConfirmClick() {
-        // todo: add logging
         _uiState.value?.selectedContentItem?.let {
+            val confirmationType = it.id.toPostResolutionConfirmationType()
+            tracker.trackConfirm(resolutionType, confirmationType)
             _triggerListeners.value = PostResolutionOverlayActionEvent.PostResolutionConfirmationEvent(resolutionType,
-                it.id.toPostResolutionConfirmationType())
+                confirmationType)
         }
         _dismissDialog.value = true
     }
 
     private fun onCloseClick() {
-        // todo: add logging
+        tracker.trackClose(resolutionType)
         _dismissDialog.value = true
     }
 
     private fun onCancelClick() {
-        // todo: add logging
+        tracker.trackCancel(resolutionType)
         _dismissDialog.value = true
     }
 
     fun onDialogDismissed() {
-        // todo: add logging
+        tracker.trackDismissed(resolutionType)
+    }
+
+    private fun onDialogShown() {
+        tracker.trackShown(resolutionType)
     }
 
     private fun onItemSelected(selectedItem: ContentItem) {