fix: Rely upon the WebView for completing non-intercepted requests #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a manual request was created for _all_ requests. This was unnecessary and resulted in header values being unexpectedly discarded.
13 tasks
jkmassel
requested changes
Oct 23, 2024
Demo-Android/Gutenberg/src/main/java/org/wordpress/gutenberg/GutenbergRequestInterceptor.kt
Outdated
Show resolved
Hide resolved
Demo-Android/Gutenberg/src/main/java/org/wordpress/gutenberg/GutenbergView.kt
Outdated
Show resolved
Hide resolved
This was added to mirror the `shouldInterceptRequest` method signature, but is unnecessary complexity.
Mirror the iOS method structure.
jkmassel
approved these changes
Oct 30, 2024
dcalhoun
deleted the
feat/authenticate-private-resource-requests-android
branch
dcalhoun
added a commit
that referenced
this pull request
Nov 1, 2024
* Add Android Request Interception * refactor: Remove redundant semi-colon Address the lint warning. * fix: Rely upon the WebView for completing non-intercepted requests (#34) * fix: Rely upon the WebView for completing non-intercepted requests Previously, a manual request was created for _all_ requests. This was unnecessary and resulted in header values being unexpectedly discarded. * refactor: Remove unused imports * refactor: Remove redundant semicolon * refactor: Remove unused import * refactor: Remove unused view parameter This was added to mirror the `shouldInterceptRequest` method signature, but is unnecessary complexity. * refactor: Separate check and handle request methods Mirror the iOS method structure. * refactor: Remove unused dependencies The networking logic that required these dependencies was hoisted to the host app. --------- Co-authored-by: David Calhoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Description
Previously, a manual request was created for all requests. This was
unnecessary and resulted in header values being unexpectedly discarded.
Testing Instructions
Tip
Test using the WPAndroid prototype build.