Skip to content

Commit

Permalink
Merge pull request #1317 from wordpress-mobile/issue/1313_carthage_build
Browse files Browse the repository at this point in the history
Fix Carthage build for Xcode 12
  • Loading branch information
SergioEstevao authored Jan 4, 2021
2 parents d37c998 + cfb4bc8 commit bec35ea
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Example/AztecExample.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,7 @@
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
SWIFT_VERSION = 4.0;
VALIDATE_WORKSPACE = YES;
};
name = Debug;
};
Expand Down Expand Up @@ -667,6 +668,7 @@
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
SWIFT_VERSION = 4.0;
VALIDATE_PRODUCT = YES;
VALIDATE_WORKSPACE = YES;
};
name = Release;
};
Expand Down Expand Up @@ -829,6 +831,7 @@
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
SWIFT_VERSION = 4.0;
VALIDATE_WORKSPACE = YES;
};
name = Profiling;
};
Expand Down Expand Up @@ -912,6 +915,7 @@
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
SWIFT_SWIFT3_OBJC_INFERENCE = Off;
SWIFT_VERSION = 4.0;
VALIDATE_WORKSPACE = YES;
};
name = "Release-Alpha";
};
Expand Down
18 changes: 18 additions & 0 deletions Example/carthage.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/usr/bin/env bash

# carthage.sh
# Usage example: ./carthage.sh build --platform iOS
# This script was copied from here: https://github.com/Carthage/Carthage/issues/3019#issuecomment-665136323

set -euo pipefail

xcconfig=$(mktemp /tmp/static.xcconfig.XXXXXX)
trap 'rm -f "$xcconfig"' INT TERM HUP EXIT

# For Xcode 12 make sure EXCLUDED_ARCHS is set to arm architectures otherwise
# the build will fail on lipo due to duplicate architectures.
echo 'EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_1200 = arm64 arm64e armv7 armv7s armv6 armv8' >> $xcconfig
echo 'EXCLUDED_ARCHS = $(inherited) $(EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_$(EFFECTIVE_PLATFORM_SUFFIX)__NATIVE_ARCH_64_BIT_$(NATIVE_ARCH_64_BIT)__XCODE_$(XCODE_VERSION_MAJOR))' >> $xcconfig

export XCODE_XCCONFIG_FILE="$xcconfig"
carthage "$@"
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ cd Example
carthage update --platform iOS
```

*If using XCode 12 use the follow script:*

```bash
cd Example
./carthage.sh update --platform iOS
```

Once Carthage finishes, you should open the file `Aztec.xcworkspace` from the root directory of Aztec.

Make sure the `AztecExample` target it selected, and press CMD + R to run it.
Expand Down

0 comments on commit bec35ea

Please sign in to comment.