Compose placeholders #1095
Open
Compose placeholders #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmandaRiu
reviewed
Dec 16, 2024
There was a problem hiding this comment.
@planarvoid Tested in the Day One app using a Samsung device and these latest changes work nicely! I made a couple minor code comments for your review. I'm not merging this PR since it looks like it may be waiting for Klym and Danilo as well, but on my end it looks good. 👍🏻
| * @param type placeholder type | ||
| * @param attributes other attributes passed to the view. For example a `src` for an image. | ||
| */ | ||
| suspend override fun insertItem(type: String, vararg attributes: Pair<String, String>) { |
There was a problem hiding this comment.
Suggested change
| suspend override fun insertItem(type: String, vararg attributes: Pair<String, String>) { | |
| override suspend fun insertItem(type: String, vararg attributes: Pair<String, String>) { |
| * @param shouldMergeItem this method should return true when the previous type is compatible and should be updated | ||
| * @param updateItem function to update current parameters with new params | ||
| */ | ||
| suspend override fun insertOrUpdateItem( |
There was a problem hiding this comment.
Suggested change
| suspend override fun insertOrUpdateItem( | |
| override suspend fun insertOrUpdateItem( |
| * @param shouldUpdateItem This function should return true if the span can be updated, false if it should be removed | ||
| * @param updateItem Function that updates the selected item | ||
| */ | ||
| suspend override fun removeOrUpdate(uuid: String, shouldUpdateItem: (Attributes) -> Boolean, updateItem: (currentAttributes: Map<String, String>) -> Map<String, String>): Boolean { |
There was a problem hiding this comment.
Suggested change
| suspend override fun removeOrUpdate(uuid: String, shouldUpdateItem: (Attributes) -> Boolean, updateItem: (currentAttributes: Map<String, String>) -> Map<String, String>): Boolean { | |
| override suspend fun removeOrUpdate(uuid: String, shouldUpdateItem: (Attributes) -> Boolean, updateItem: (currentAttributes: Map<String, String>) -> Map<String, String>): Boolean { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In this PR I'm implementing a parallel solution that allows you to draw placeholders in Jetpack Compose instead of Android Views. This is actually more reliable, especially when considering redrawing which was hard to do with AV.
I created the compose placeholder manager from the previous manager and cleaned up things that I think are not necessary with compose. It should be much more straightforward because the compose view should be redrawn when the state changes without any forced redrawns.
This PR is much smaller than it seems because
ViewPlaceholderManageris just a rename ofPlaceholderManagerso it doesn't need to be reviewed.Test
Test this feature with the related DO PR.
Review
@danilo04
Make sure strings will be translated:
strings.xmlas a part of the integration PR.