[자판기] 김형준 미션 제출합니다. #162
Open
[자판기] 김형준 미션 제출합니다. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaegeonYu
reviewed
Dec 4, 2022
| } | ||
|
|
||
| public String toMessage() { | ||
| String prefix = "[ERROR] "; |
JaegeonYu
reviewed
Dec 4, 2022
| private final char ORDER_PREFIX = '['; | ||
| private final char ORDER_SUFFIX = ']'; | ||
| private final char ORDER_SEPARATOR = ';'; | ||
| private final char ORDER_INFO_SEPARATOR = ','; |
There was a problem hiding this comment.
validation에 사용할 문자들을 따로 빼주는 좋은 아이디어 인것 같아요
JaegeonYu
reviewed
Dec 4, 2022
| } | ||
|
|
||
| public void showAllCoins(Change change) { | ||
| HashMap<Integer, Integer> coinMap = change.getCoins(); |
There was a problem hiding this comment.
Change에서 tostring으로 넘겨주고 print class 에선 print만 하면 좋을 것 같아요
chonahyeon
reviewed
Dec 4, 2022
| package vendingmachine.Constant; | ||
|
|
||
| public enum Error { | ||
| INPUT_ALLOWED_ONLY_NUMBER("금액은 숫자만 입력이 가능합니다."), |
Choi-JJunho
reviewed
Dec 4, 2022
| public List<Product> toProducts(String userInput) { | ||
| List<Product> products = new ArrayList<>(); | ||
|
|
||
| for (String productInfo : userInput.split(";")) { |
There was a problem hiding this comment.
해당 객체를 다른 곳에서 사용할때 검증되지 않은 값이 들어올 수 있다고 생각되서 validation이 있으면 좋을것같아요.
chonahyeon
reviewed
Dec 4, 2022
chonahyeon
reviewed
Dec 4, 2022
| } | ||
|
|
||
| private int productSold(String productName) { | ||
| for (Product productOfMenu : products) { |
There was a problem hiding this comment.
지금은 물건의 수가 별로 없는 예제라 괜찮지만 물건의 수가 많다면 이렇게 한바퀴 도는 것 보단 상품명을 key로 두고 key로 검색해서 처리하는게 좋을 것 같아요. HashMap<String,Product> 이런식으로요!
Choi-JJunho
reviewed
Dec 4, 2022
|
같은 로직인데도 코드가 깔끔해서 많이 배워가요 👍👍👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.