[MVC 구현] 달리(김동연) 3단계 미션 제출합니다. #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngh0
requested changes
Sep 26, 2023
| return new ModelAndView(new JspView(viewName)); | ||
| } | ||
|
|
||
| @RequestMapping(value = "/login", method = RequestMethod.POST) |
|
|
||
| public HandlerAdaptors() { | ||
| this.adaptors = new ArrayList<>(); | ||
| adaptors.add(new ManualHandlerAdaptor()); |
There was a problem hiding this comment.
현재 ManualHandler 는 사용하지 않는 상태인데, Manual 방식을 이용하는 Controller 를 대비해서 add() 하시는 건가요??
저도 ManualHandler 관련 클래스를 삭제할지 말지 고민했었어서 질문드립니다!
There was a problem hiding this comment.
저도 이거 어떻게할까 고민했는데 2단계의 목적이 기존의 레거시 코드를 사용하던 프로그램에서도 돌아갈 수 있게 유지하는 거라면 기존 버전을 사용하는 사람들 위해 남겨두는 것이 맞지 않을까 하여 남겨두었씁니다.
| @Override | ||
| public void render(final Map<String, ?> model, final HttpServletRequest request, HttpServletResponse response) | ||
| throws Exception { | ||
| Writer writer = response.getWriter(); | ||
| objectMapper.writeValue(writer,model); |
There was a problem hiding this comment.
요구사항에 model size 관련한 내용이 있는데 한 번 확인해보시면 좋을 것 같습니다!!
| import java.util.Map; | ||
| import webmvc.org.springframework.web.servlet.View; | ||
|
|
||
| public class JsonView implements View { | ||
|
|
||
| ObjectMapper objectMapper = new ObjectMapper(); |
| import webmvc.org.springframework.web.servlet.mvc.adaptor.HandlerAdaptors; | ||
| import webmvc.org.springframework.web.servlet.mvc.adaptor.HandlerMappings; | ||
|
|
||
| public class DispatcherServlet extends HttpServlet { |
youngh0
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 레오!
리뷰 신청이 늦어서 죄송합니다 ㅠㅠ
잘부탁 드립니다.