Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVC 구현하기 - 3단계] 에코(조은찬) 미션 제출합니다. #626
[MVC 구현하기 - 3단계] 에코(조은찬) 미션 제출합니다. #626
Changes from 1 commit
d4f1d98
00c83b1
0c7d549
74aa413
a2ee4d2
7bd858e
a423a95
68233c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 분리를 한다면 getModelMessage() 라던가?
더 가독성이 높아질 것 같은데 에코 의견이 궁금합니다.
render 안에서 response 세팅과 model json 을 만드는 과정이 어색하지는 않지만, 에코의 의견이 궁금해요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 아무래도 render라는 메서드에 json body 생성, Response header 설정, Response에 body 작성 등 여러 작업을 하더라구요! 그래서 우가 얘기해주신대로 분리가 가능할 것 같았고, 해당 부분은 아래와 같이 createJsonBody 메서드로 분리했습니다! 확실히 가독성이 좋아졌네요 ㅎㅎ