[MVC 구현하기 - 3단계] 오잉(이하늘) 미션 제출합니다 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woosung1223
requested changes
Sep 25, 2023
There was a problem hiding this comment.
안녕하세요 오잉!
깔끔하게 잘 구현해주셨습니다~
try-with-resources를 통한 자원정리까지 완벽합니다 👍
사소한 부분에 대해서만 피드백 남겼습니다!
수정하시고 리뷰요청해주시면 바로 merge 하겠습니다~!
궁금한 점
DispatcherServletInitialIzer를 mvc모듈로 내릴 수 없는 이유가 뭘까요?!
다양한 이야기가 나오고 있는 것 같아서 테오의 의견도 궁금합니다!
저도 그 문제를 겪었는데, 모듈을 옮기면 ServletContainerInitializer가 스캔을 못하는 거 같더라구요.
아직 저도 명확한 해답을 찾지는 못했지만.. 서블릿 컨테이너의 동작 과정과 연관되어 있지 않을까요?
webInitializerClasses 를 어디서 스캔하는건지 알면 해결할 수 있을 것 같은데, 아직까지는 저도 원인파악이 안되고 있는 상태입니다 😅
app/src/main/java/com/techcourse/controller/LoginController.java
Outdated
Show resolved
Hide resolved
mvc/src/main/java/webmvc/org/springframework/web/servlet/view/JsonView.java
Show resolved
Hide resolved
mvc/src/main/java/webmvc/org/springframework/web/servlet/view/JsonView.java
Show resolved
Hide resolved
woosung1223
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 테오!
JspView는 저번 단계에서 해버려서
이번 단계에서는
만 진행했습니다!
궁금한 점
DispatcherServletInitialIzer를 mvc모듈로 내릴 수 없는 이유가 뭘까요?!
다양한 이야기가 나오고 있는 것 같아서 테오의 의견도 궁금합니다!
3단계도 잘 부탁드립니다~~👨🎤