[MVC 구현하기 - 3단계] 푸우(백승준) 미션 제출합니다. #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choi-JJunho
approved these changes
Sep 25, 2023
Comment on lines
+38
to
+50
| private class JunHo { | ||
|
|
||
| private List<String> names = List.of("junho", "junho2"); | ||
| private Integer age = 100; | ||
|
|
||
| public List<String> getNames() { | ||
| return names; | ||
| } | ||
|
|
||
| public Integer getAge() { | ||
| return age; | ||
| } | ||
| } |
| import webmvc.org.springframework.web.servlet.mvc.tobe.exception.HandlerNotFoundException; | ||
| import webmvc.org.springframework.web.servlet.view.JspView; | ||
|
|
||
| public class ExceptionHandler { |
There was a problem hiding this comment.
오..!! 예외상황을 위한 Exception Handler 좋네요 👍
Comment on lines
+13
to
+14
| public static final int SINGLE_DATA_RESPONSE = 1; | ||
| public static final int NOT_RESPONSE_BODY = 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 Junho 미션 3 구현하고 리뷰 요청드립니다!!
구현한 내용은 다음과 같습니다.
3번 요구사항을 지키는 과정에서 NotFoundController 를 어떻게 처리할지 고민이었네요 🤔
이번에 구현한 방식은 HandlerMapping 에서 Handler 가 없을 경우 예외를 발생시키고,
해당 예외를 처리하는 ExceptionHandler 를 구현하여 처리했습니다.
이 부분을 어떻게 처리하면 좋을지 주노의 의견이 궁금합니다!!
리뷰 감사드립니다☺️