[MVC 구현하기 - 3단계] 하마드(이건회) 미션 제출합니다. #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawfishthelgh
changed the title
gitchannn
requested changes
Sep 25, 2023
| String jsonString = objectMapper.writeValueAsString(model); | ||
| PrintWriter printWriter = response.getWriter(); | ||
| response.setContentType(MediaType.APPLICATION_JSON_UTF8_VALUE); | ||
| printWriter.write(jsonString); |
| @@ -20,11 +19,6 @@ public class ManualHandlerMapping implements HandlerMapping { | |||
| @Override | |||
| public void initialize() { | |||
| controllers.put("/", new ForwardController("/index.jsp")); | |||
gitchannn
approved these changes
Sep 26, 2023
|
|
||
| @RequestMapping(value = "/", method = RequestMethod.GET) | ||
| public ModelAndView showPage(HttpServletRequest request, HttpServletResponse response) { | ||
| return new ModelAndView(new JspView("/index.jsp")); |
| printWriter.write(jsonString); | ||
| } | ||
|
|
||
| private String extractJsonString(Map<String, ?> model, ObjectMapper objectMapper) throws JsonProcessingException { |
There was a problem hiding this comment.
extract보다는 generate에 가까운 것 같지만!
이름 정도는 넘어가보겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
깃장(git long) 안녕하세요.
하마드입니다.
저번에 주신 소중한 리뷰 확인하고 반영해봤습니다ㅎㅎ
말씀주신대로, Mapper 관련 클래스를 비즈니스 로직이 결합된 패키지와 분리시키면
관심사의 분리가 일어나 비즈니스 로직에 집중할 수 있는 패키지 구조가 될 수 있는 것 같네요.
좋은 지적 감사합니다~!
/view가 존재하는 api도 모두 제거하고 통일시켜 봤습니다. 이번에도 좋은 리뷰 부탁해요~!